Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190422065623.49364-1-weizhenliang@huawei.com>
In-Reply-To: <20190422065623.49364-1-weizhenliang@huawei.com>
From:   Christian Brauner <christian@brauner.io>
Date:   Mon, 22 Apr 2019 12:37:05 +0200
Message-ID: <CAHrFyr4rD04qzwDb30h3RMLGPq+OLVGk1Kr8izfAaizkVE43UQ@mail.gmail.com>
Subject: Re: [PATCH v2] signal: trace_signal_deliver when signal_group_exit
To:     Zhenliang Wei <weizhenliang@huawei.com>
Cc:     "Eric W. Biederman" <ebiederm@xmission.com>,
        Oleg Nesterov <oleg@redhat.com>, colona@arista.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 22, 2019 at 8:57 AM Zhenliang Wei <weizhenliang@huawei.com> wrote:
>
> In the following commit, removing SIGKILL from each thread signal mask
> and executing "goto fatal" directly will skip the call to
> "trace_signal_deliver". At this point, the delivery tracking of the SIGKILL
> signal will be inaccurate.
>
> commit cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")
>
> Therefore, we need to add trace_signal_deliver before "goto fatal"
> after executing sigdelset.
>
> Note: The action[SIGKILL] must be SIG_DFL, and SEND_SIG_NOINFO matches
> the fact that SIGKILL doesn't have any info.
>
> Signed-off-by: Zhenliang Wei <weizhenliang@huawei.com>

Just a nit below otherwise

Acked-by: Christian Brauner <christian@brauner.io>

You should probably make the line:
commit cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")
a Fixes-line right above your commit:
Fixes cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")

> ---
>  kernel/signal.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 227ba170298e..0f69ada376ef 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
>         if (signal_group_exit(signal)) {
>                 ksig->info.si_signo = signr = SIGKILL;
>                 sigdelset(&current->pending.signal, SIGKILL);
> +               trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
>                 recalc_sigpending();
>                 goto fatal;
>         }
> --
> 2.14.1.windows.1
>
>