Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESEND] regulator: max77620: Fix regulator info setting
 for max20024
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Mark Zhang <markz@nvidia.com>,
        Venkat Reddy Talla <vreddytalla@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20190422053531.23123-1-axel.lin@ingics.com>
 <74253ed2-6b5a-0e59-25f0-05d7d8ce5431@gmail.com>
Message-ID: <84db2f6a-f1b5-bd15-83ce-24ab321dff64@gmail.com>
Date:   Mon, 22 Apr 2019 14:44:09 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <74253ed2-6b5a-0e59-25f0-05d7d8ce5431@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

22.04.2019 14:39, Dmitry Osipenko пишет:
> 22.04.2019 8:35, Axel Lin пишет:
>> Current code always set pmic->rinfo[id] = &max77620_regs_info[id];
>> It should set to either max77620_regs_info or max20024_regs_info
>> depends on the chip_id.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> This was sent on https://lkml.org/lkml/2019/2/23/482
>>
>>  drivers/regulator/max77620-regulator.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
>> index 1607ac673e44..0ad91a7f9cb9 100644
>> --- a/drivers/regulator/max77620-regulator.c
>> +++ b/drivers/regulator/max77620-regulator.c
>> @@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev)
>>  			continue;
>>  
>>  		rdesc = &rinfo[id].desc;
>> -		pmic->rinfo[id] = &max77620_regs_info[id];
>> +		pmic->rinfo[id] = &rinfo[id];
>>  		pmic->enable_power_mode[id] = MAX77620_POWER_MODE_NORMAL;
>>  		pmic->reg_pdata[id].active_fps_src = -1;
>>  		pmic->reg_pdata[id].active_fps_pd_slot = -1;
>>
> 
> That is a quite difficult bug to spot because the regulator parameters are mostly identical and the part that differs is usually unused in practice, good catch! Thank you very much!
> 
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> 

Axel, please also add a stable tag to the commit message to get the fix backported.

Cc: stable <stable@vger.kernel.org>