Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2586315yba; Mon, 22 Apr 2019 09:21:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSjMe0Lkd4v0K++51IgDo9L7euTdqS2wdiFy+xsy9SyNjdKIi6iwHHp5jcAF2nKakUMn8N X-Received: by 2002:a62:b418:: with SMTP id h24mr20985760pfn.145.1555950073669; Mon, 22 Apr 2019 09:21:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555950073; cv=none; d=google.com; s=arc-20160816; b=rz3fVh3oTpdhjdQ3rdE0WlT28s3RgVCfQ0kySPY1RisDU1YKKbOKG38CwQLR4hRLcT ZwCUUh9+2ky51RInbVQxYgWpKvflQ6NgVPARGK/w2hM+Aag2U5SYRnkJik1k3UeDeDjc buFvhANdxRRDUQAsCRBPfLs/lATWNKYqzQjzkxyUHrRyzrXImselAtIs1/9tPrPeyMD5 5v0+31QpxzIBkyFgL0RPD310mepEKl7ahAq2/mXvVpd670jiQ+IY/y/6/Wuqp7klmxjl knlXaQWSL5xpPldl637zN+hZY/oVmpwZsrFbPGoTWWwdEbNa0pKbgSPJF/aYxBXKCAO/ Qh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cfcV4SYZj1boy6fqgNvcFWK/DXUYNfImqsmIJFgzJmg=; b=Z4990/lpQnpPWpR38aqYmsGT/cau07braNiYS7ajqWO/DVUcVfPIqRMFPLD0+1hjlh XB/d0r8p/37rQFUFhHTmj+FSLtmUmEldlK6UE29vi23voTVE4Q/fz+Hh1sj9EdG7u8so IA7DWSbQFL6N+HIoLwv0/5j3baAWXnmVj4MZj2vpBzclCaQ0XxxmtXws3kQzPI3rxZ1u sQgKylTH8flcPZREO71YHQC/k/EB1ye/MHVozExWELpMopcchNNIkC+4K1U+vnvbUlh/ FV16Irm7jPc8fPkqimcmMtz6D1GbG8YmS4ELw0x1H+BzL16kg4xJCjUFDmu+qDY7h4f0 kjpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si11840769pgh.8.2019.04.22.09.20.57; Mon, 22 Apr 2019 09:21:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbfDVPFg (ORCPT + 99 others); Mon, 22 Apr 2019 11:05:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbfDVPFg (ORCPT ); Mon, 22 Apr 2019 11:05:36 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBC9DA70E; Mon, 22 Apr 2019 15:05:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.38]) by smtp.corp.redhat.com (Postfix) with SMTP id AA710600CC; Mon, 22 Apr 2019 15:05:33 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 22 Apr 2019 17:05:35 +0200 (CEST) Date: Mon, 22 Apr 2019 17:05:32 +0200 From: Oleg Nesterov To: Zhenliang Wei Cc: ebiederm@xmission.com, colona@arista.com, akpm@linux-foundation.org, christian@brauner.io, arnd@arndb.de, tglx@linutronix.de, deepa.kernel@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] signal: trace_signal_deliver when signal_group_exit Message-ID: <20190422150532.GA20151@redhat.com> References: <20190422065623.49364-1-weizhenliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422065623.49364-1-weizhenliang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 22 Apr 2019 15:05:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/22, Zhenliang Wei wrote: > > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig) > if (signal_group_exit(signal)) { > ksig->info.si_signo = signr = SIGKILL; > sigdelset(¤t->pending.signal, SIGKILL); > + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); > recalc_sigpending(); > goto fatal; > } Reviewed-by: Oleg Nesterov