Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2597042yba; Mon, 22 Apr 2019 09:32:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwW/8xA+ao9AM7Et7bcz16y+jwHFy+ERc5CQwZsgoc3oCEF5xkm5vMRW3kEob8rCDLXr/Ps X-Received: by 2002:aa7:9f9c:: with SMTP id z28mr21203981pfr.244.1555950739545; Mon, 22 Apr 2019 09:32:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555950739; cv=none; d=google.com; s=arc-20160816; b=GlTk5b3+JSEzclZ/lGO4H8FTnzD7ql+jJaNvKu6HD37ihNyYbcdFdf1jV+OgmvGGde pUnpyY6VHml9r8R364ccUhQLlwoGvL/agZKo2/4C8cclO1qE94y+biTeC6Lc8cUT6+Cd KrzNzaayq1a2rQLfFqXTf2lvMZXHFu51LEs4K/OQe8mT/qkEyg8i5Kx0krE+jBFbF0r8 fi3gRELKTve1KTTY/xb2inRO53LQqZJ69Fu30RsYlF1d2U5kafCEgIWsjNalSHnNUunG rnWDM8nkUVWA5BjF1O2Nv5VSndq/acqgCHowTsFPalSGVw4VvUhMHz5cXK1PNkfZYOBj DElA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cfcV4SYZj1boy6fqgNvcFWK/DXUYNfImqsmIJFgzJmg=; b=nLF/jkI70Hpp7qou+915Z0vbfWstQl7FjsJd5wT7UnUZwR/p3L9a4aktriYMcULv/r IjZyfDfLYMrViwNCyT+9qQoYFXh054FSOrbBnICSzfXoOvZ7LAS2kEeCBLGWQ34ZAE5N sUDpmzpGLguxyOqRtLDnyPDOQgUJcGDEFcEbljwqN9qe/ADSIHChRiggCVA477hfq/hk JiOET3LfG0AJwWLqrJ+9MPlC6fwcDIW9Xt78Z4T3e2a8J+D5v5kcN45KGZ/BBb4S6YmJ VIbK7tp2Imkisj1ZP10J9BxLaZmJicvNJxKaYzQb1J1WA2BW2vEH7DHa2EQYvALiu/ri obDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si13457042pfc.276.2019.04.22.09.32.04; Mon, 22 Apr 2019 09:32:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbfDVPZ0 (ORCPT + 99 others); Mon, 22 Apr 2019 11:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726943AbfDVPZZ (ORCPT ); Mon, 22 Apr 2019 11:25:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A9083092659; Mon, 22 Apr 2019 15:25:25 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.38]) by smtp.corp.redhat.com (Postfix) with SMTP id 6F51F60C9C; Mon, 22 Apr 2019 15:25:23 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 22 Apr 2019 17:25:25 +0200 (CEST) Date: Mon, 22 Apr 2019 17:25:22 +0200 From: Oleg Nesterov To: Zhenliang Wei Cc: ebiederm@xmission.com, colona@arista.com, akpm@linux-foundation.org, christian@brauner.io, arnd@arndb.de, tglx@linutronix.de, deepa.kernel@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit Message-ID: <20190422152522.GB20151@redhat.com> References: <20190422145950.78056-1-weizhenliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422145950.78056-1-weizhenliang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 22 Apr 2019 15:25:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/22, Zhenliang Wei wrote: > > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig) > if (signal_group_exit(signal)) { > ksig->info.si_signo = signr = SIGKILL; > sigdelset(¤t->pending.signal, SIGKILL); > + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); > recalc_sigpending(); > goto fatal; > } Reviewed-by: Oleg Nesterov