Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 22 Apr 2019 21:40:53 +0200
From:   Florian Westphal <fw@strlen.de>
To:     Andreas Hartmann <andihartmann@freenet.de>
Cc:     Florian Westphal <fw@strlen.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4.19 13/99] netfilter: nf_conncount: fix argument order
 to find_next_bit
Message-ID: <20190422194053.k6h4cunlfpjlt5wk@breakpoint.cc>
References: <20190121134913.924726465@linuxfoundation.org>
 <20190121134914.421023706@linuxfoundation.org>
 <f55ad830-dd61-8ce2-7fa0-d33fb93c0b9c@01019freenet.de>
 <20190422172732.sneybhuwrreb7g2u@breakpoint.cc>
 <c9211352-3da4-6cb6-cd71-be0b9c0248d7@01019freenet.de>
 <20190422185710.3la4ayzxslafxwbn@breakpoint.cc>
 <47f69e73-8104-aa58-44f2-b0d8fafd9e91@maya.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47f69e73-8104-aa58-44f2-b0d8fafd9e91@maya.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Andreas Hartmann <andihartmann@freenet.de> wrote:
> On 22.04.19 at 20:57 Florian Westphal wrote:
> > grep CONNCOUNT ~/your_kernel_conf
> 
> True - it's not in use (it's not even configured) at all. I'm surprised that it seems to fix the problem anyway.

Thats usually the main problem when testing for a bug that doesn't
appear often -- its too easy to get bisections wrong and end up
with false positives.

> If I can't see it any more - I wouldn't know what to do any further at the moment.

You could try enabling some of the debug features, such as
CONFIG_PROVE_{LOCKING,RCU}.

It would e.g. tell if we forget an unlock somewhere.