Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ab7b65d29dbd7623c679c4ef91352d594a24f39a.1555921081.git.leonard.crestez@nxp.com>
References: <cover.1555921081.git.leonard.crestez@nxp.com> <ab7b65d29dbd7623c679c4ef91352d594a24f39a.1555921081.git.leonard.crestez@nxp.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH 2/3] scripts/gdb: Initial clk support: lx-clk-summary
To:     Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Leonard Crestez <leonard.crestez@nxp.com>
Message-ID: <155596452161.15276.15842111427229300135@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Mon, 22 Apr 2019 13:22:01 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Leonard Crestez (2019-04-22 01:26:57)
> +
> +
> +class LxClkSummary(gdb.Command):
> +    """Print Linux kernel log buffer."""

This comment needs an update.

> +
> +    def __init__(self):
> +        super(LxClkSummary, self).__init__("lx-clk-summary", gdb.COMMAND=
_DATA)
> +
> +    def show_subtree(self, clk, level):
> +        gdb.write("%*s%-*s %7d %8d %8d\n" % (
> +                level * 3 + 1, "",
> +                30 - level * 3,
> +                clk['name'].string(),
> +                clk['enable_count'],
> +                clk['prepare_count'],
> +                clk['protect_count']))

Would be nice to also print the rate, phase, etc. It's all pretty much
there already so it's just dumping data out. If it's a clk that has
CLK_GET_RATE_NOCACHE then I guess we have to print out '<unknown>'
because it relies on runtime code execution.

> +
> +        for child in clk_core_for_each_child(clk['children']):
> +            self.show_subtree(child, level + 1)