Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3145693yba; Mon, 22 Apr 2019 21:15:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUPXGBSHObRA6Quo8VKaDyGuQIwULIK/dE7/Y5Ul8VETyIMrvz7tSoIDQC+2gzsjTi+DEk X-Received: by 2002:a17:902:28a9:: with SMTP id f38mr23647887plb.295.1555992939372; Mon, 22 Apr 2019 21:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555992939; cv=none; d=google.com; s=arc-20160816; b=omlWRT5l8oqUEeHmfKO9PbToY0GhmjAlWqALGxNZ0snmEfBOqHeyX3Hk9vwEUelyu3 N7NbAL3nqYg0qzegHfX13txkW+qDjoe/yLpdE/vV0IuVVWjr5zB7gUdlJguyK9VGPmet zmOcYt4Bg98GBrMnAzWY2f+Qhw2cOQEgEGClgPdxj/ZHp3iUD2eYK+00i54qiqFSC4j3 gQb07NH6DieWCF3qnQBwyUsJOsXHnjP9kiXy0LUbg2TZ4WVGXi7OjFnsOnzEJ0vI5wRd RCozU4gpNcw7xVW6O2Wn+zxxL1f87obN1t4vSW/eWrySb+5ubeNLcVd+uJ5W9Cj5N/VW VG6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=28XRunKZqk302aWQvnGDqHbIv4f3LZqkkzFgLwUiH68=; b=qXuzcQhlg5Ke3nuOe9UEvDUISI5J54eUASnTrghild622/Sy7YVLD/XTLRNY5M3yw/ YoNv+sJNkKjZYgXhpiJSxx6Vo2zNmIkG7ZYHGia9/tQllPyTypObnKzwEyTdAKho2dBk 89jCOIHhuw/Fz6WGO/agAr8FnunhmulDTU1LqMPYDQmvQTRT+fn/HVhGP6eGezGJMgWB mGIeTyT5JNX1s9DaE1LwaCu/uClErrxkM1a2kgPaHGYDAoQrvA0girh+wynT2Jq053bh NG6nJydTs3tjm2y2/hTHCeQmoASGdoICzm444WvOOgD19AOjHzm6xRCAE0iaoKVTBB7L Y/3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cPKPpRCR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6si4289635pgj.225.2019.04.22.21.15.23; Mon, 22 Apr 2019 21:15:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cPKPpRCR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730064AbfDWCUY (ORCPT + 99 others); Mon, 22 Apr 2019 22:20:24 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:42033 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbfDWCUY (ORCPT ); Mon, 22 Apr 2019 22:20:24 -0400 Received: by mail-yw1-f68.google.com with SMTP id y131so2406175ywa.9 for ; Mon, 22 Apr 2019 19:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=28XRunKZqk302aWQvnGDqHbIv4f3LZqkkzFgLwUiH68=; b=cPKPpRCRXvn1m0JbaAyFsGAdgTV2t16TjPQrMFdwHDpU8V3uWSvfgCMRH3HG0VEWxL gzO7xgmxQyx5ztcqoDnU/j0e00DsCmT523p+nxKuvWrCOTIqyaYJ9nvRhLbHqogxonPu G3UZFFDyjsg9o/f+S9tOdtGgGRJNtbh91OLY6Si34UJJ6FqJxQGRJR1u4Dh+PLh1jSG9 e1l1bZErI56CHPPvmQz9SbLkrXmGbH21Sh/4rJ18kAs00CKseTWDsnTZTe8wg99nTIA8 j7HXluqYPVw/fP5bywovbodztbc6qD3lVVqdf3/Kk9WRwvI3oB8sidrRy3Ql2p3WFeE0 5FaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=28XRunKZqk302aWQvnGDqHbIv4f3LZqkkzFgLwUiH68=; b=PCWOslW9h6UmNuRDlAfwvJoolj3SVDdtNVmuFKSM9Qr9lMJe3QLZ6KCpjNcte1YDrw i9WHvwIUkcaj6qt4cYJkceMel/kPi763Fy/XZSTRnGwg/Xt39N3WL0iBxuI/o4uOctnx bDn7wYkvoGMLq76P5MPEevKSNHS1sLB9eMVfY7iru2DzrPpDw4HqyaNVLSDNTULlPccf cJGv3Mz+a9ESW3wjlRSai4Ut+ZbnVEnN0GjNp/kC2+qUyttcrTHFZCwyRi2EgC+seqss NTT9H/bolACOINCrkKyGxpmCIPqmNXtlw1o5/6DUCFxnfOEbNqhOJTOidc4up8D4zEMl BwTA== X-Gm-Message-State: APjAAAWkwdXirV9B3kYGDvNKdzrunysvQG2hB7SS2v3USuAB7aOb4uab kRBbDEnjrDbgDhH0y37J5+0= X-Received: by 2002:a0d:c745:: with SMTP id j66mr19238750ywd.258.1555986023664; Mon, 22 Apr 2019 19:20:23 -0700 (PDT) Received: from localhost.localdomain ([191.101.9.198]) by smtp.gmail.com with ESMTPSA id k189sm4744066ywa.48.2019.04.22.19.20.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 19:20:23 -0700 (PDT) From: Bo YU To: gregkh@linuxfoundation.org, christian.gromm@microchip.com, colin.king@canonical.com, andrey.shvetsov@k2l.de Cc: Bo YU , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: most: protect potential string overflow Date: Mon, 22 Apr 2019 22:20:18 -0400 Message-Id: <20190423022018.12214-1-tsu.yubo@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There maybe cause potential string overflow issue due to use strcpy without checking the length Detected By CoversityScan CID# 1444760 Fixes: 131ac62253dba:(staging: most: core: use device description as name) Signed-off-by: Bo YU --- drivers/staging/most/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c index 956daf8c3bd2..0f26cebac91a 100644 --- a/drivers/staging/most/core.c +++ b/drivers/staging/most/core.c @@ -1431,7 +1431,7 @@ int most_register_interface(struct most_interface *iface) INIT_LIST_HEAD(&iface->p->channel_list); iface->p->dev_id = id; - strcpy(iface->p->name, iface->description); + strlcpy(iface->p->name, iface->description, sizeof(iface->p->name)); iface->dev.init_name = iface->p->name; iface->dev.bus = &mc.bus; iface->dev.parent = &mc.dev; -- 2.11.0