Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190422050344.24513-1-crag0715@gmail.com> <20190422133947.0b6aaf82@cakuba.netronome.com>
In-Reply-To: <20190422133947.0b6aaf82@cakuba.netronome.com>
From:   Crag Wang <crag0715@gmail.com>
Date:   Tue, 23 Apr 2019 10:52:21 +0800
Message-ID: <CAP-8N0g4s2o7p1oL9swBUEjfiyxnU=4Xf2CXu2Fo-1+a2L2J8A@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] r8152: sync sa_family with the media type of
 network device
To:     Jakub Kicinski <jakub.kicinski@netronome.com>
Cc:     linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, hayeswang@realtek.com,
        Mario Limonciello <mario_limonciello@dell.com>,
        "Crag.Wang" <crag.wang@dell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Simon Glass <sjg@chromium.org>,
        Grant Grundler <grundler@chromium.org>,
        Sean Paul <seanpaul@chromium.org>,
        David Chen <david.chen7@dell.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Charles Hyde <charles.hyde@dell.corp-partner.google.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        zhong jiang <zhongjiang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 23, 2019 at 4:39 AM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> On Mon, 22 Apr 2019 13:03:43 +0800, crag0715@gmail.com wrote:
> > From: "Crag.Wang" <crag.wang@dell.com>
> >
> > Without this patch the socket address family sporadically gets wrong
> > value ends up the dev_set_mac_address() fails to set the desired MAC
> > address.
> >
> > Signed-off-by: Crag.Wang <crag.wang@dell.com>
>
> Code looks reasonable.  This must have been caused by:
>
> Fixes: 25766271e42f ("r8152: Refresh MAC address during USBDEVFS_RESET")
>
> which is still in net-next.  In the future please make sure you read:
>
> https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
>
> In particular:
>
> https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
>
> To assure smooth flow of your patches into the tree :)
>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>
Yes, patch is intended to fix 25766271e42f which is still in net-next.

It appears that prefix is desired in the subject. Thanks for sharing the info.

Crag