Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Mario.Limonciello@dell.com>
To:     <crag0715@gmail.com>, <linux-usb@vger.kernel.org>,
        <netdev@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <hayeswang@realtek.com>,
        <Crag.Wang@dell.com>, <davem@davemloft.net>, <sjg@chromium.org>,
        <grundler@chromium.org>, <seanpaul@chromium.org>,
        <David.Chen7@Dell.com>, <kai.heng.feng@canonical.com>,
        <gustavo@embeddedor.com>,
        <charles.hyde@dell.corp-partner.google.com>,
        <bigeasy@linutronix.de>, <zhongjiang@huawei.com>
Subject: RE: [PATCH v2 1/1] r8152: sync sa_family with the media type of
 network device
Thread-Topic: [PATCH v2 1/1] r8152: sync sa_family with the media type of
 network device
Thread-Index: AQHU+MjgKSyFOMW2wUS7aSLiRqzwkqZIstlw
Date:   Mon, 22 Apr 2019 21:29:36 +0000
Message-ID: <e6c274bbd120446fb58ceb6ba9528b4b@ausx13mpc124.AMER.DELL.COM>
References: <20190422050344.24513-1-crag0715@gmail.com>
In-Reply-To: <20190422050344.24513-1-crag0715@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: crag0715@gmail.com <crag0715@gmail.com>
> Sent: Monday, April 22, 2019 12:04 AM
> To: linux-usb@vger.kernel.org; netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; hayeswang@realtek.com; Limonciello, Mar=
io;
> crag0715@gmail.com; Wang, Crag; David S. Miller; Simon Glass; Grant Grund=
ler;
> Sean Paul; Chen7, David; Kai-Heng Feng; Gustavo A. R. Silva; Charles Hyde=
;
> Sebastian Andrzej Siewior; zhong jiang
> Subject: [PATCH v2 1/1] r8152: sync sa_family with the media type of netw=
ork
> device
>=20
>=20
> [EXTERNAL EMAIL]
>=20
> From: "Crag.Wang" <crag.wang@dell.com>
>=20
> Without this patch the socket address family sporadically gets wrong
> value ends up the dev_set_mac_address() fails to set the desired MAC
> address.

Ah yes, this is because of an uninitialized struct sockaddr, so random garb=
age.
I didn't catch it during my testing, good catch.

>=20
> Signed-off-by: Crag.Wang <crag.wang@dell.com>
> ---
>  drivers/net/usb/r8152.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 4c63b40d5e00..41fb39ce69c9 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp=
,
> struct sockaddr *sa)
>  	struct net_device *dev =3D tp->netdev;
>  	int ret;
>=20
> +	sa->sa_family =3D dev->type;
> +
>  	if (tp->version =3D=3D RTL_VER_01) {
>  		ret =3D pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
>  	} else {
> --
> 2.20.1

Reviewed-By: Mario Limonciello <mario.limonciello@dell.com>