Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Junichi Nomura <j-nomura@ce.jp.nec.com>
To:     Kairui Song <kasong@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Chao Fan" <fanc.fnst@cn.fujitsu.com>, Baoquan He <bhe@redhat.com>,
        Dave Young <dyoung@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] x86/kexec: always ensure EFI systab region is mapped
Thread-Topic: [PATCH] x86/kexec: always ensure EFI systab region is mapped
Thread-Index: AQHU+O3agAmzlxHZg0mE9lemKT/NC6ZIsHeA
Date:   Tue, 23 Apr 2019 06:20:09 +0000
Message-ID: <965f770a-b103-72fb-eaef-cb337ebe8290@ce.jp.nec.com>
References: <20190422092804.15534-1-kasong@redhat.com>
In-Reply-To: <20190422092804.15534-1-kasong@redhat.com>
Accept-Language: en-US, ja-JP
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <92F1F186A0F7274C960CCFCB661342A2@gisp.nec.co.jp>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/22/19 6:28 PM, Kairui Song wrote:
> The reason is the systab region is not mapped by the identity mapping
> provided by kexec. Currently kexec only create identity mapping for
> mem regions, wihch won't cover the systab. So second kernel will be
> accessing a not mapped memory region and cause fault.
> But as kexec tend to pad the map region up to PUD size, the
> systab could be included in the map by accident, so it worked on
> some machines, but that will be broken easily and unstable.

Is the mapping of ACPI tables just by luck, too?

-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.