Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3305691yba; Tue, 23 Apr 2019 01:10:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzwqlDuae3vAEbR2YPthBeoE1j1xN4DSMNik545aRcEhDO8UpnndkVwlJCfIPpv6RM9N1UU X-Received: by 2002:a65:414a:: with SMTP id x10mr23246105pgp.237.1556007003269; Tue, 23 Apr 2019 01:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556007003; cv=none; d=google.com; s=arc-20160816; b=Kw/CezeK/GouO0hN9e8oJwkAM+/p7NZkpvuprJqnS5BTgb8+UhDbFs5Gr64dY1EjLH b1qeCd+HSM+CNzTfAhr02f7q2o371W28ek3bgZt3N2UzQM5zgcTtj17uh6Ve2caTxDuQ 3GOqaAMzSGgodBVq4nClUtR4wcNpRB28qt5lJyiYV6/UcTosfIq+4vA2HOjnyJEyUyx+ BGYSyQc521fksYOh9clmnt2qzG5QFxY48fOTr3gUBh2KutiVPpOJlAA2+xzo2XsqVIko 0uURYfwBiygKwUNtGu+PJc3eAON1RbalCJ8fMvLFjXNLjM8GvCXBiRx9NDv50BszztPe H8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=uDrSofO2njDoa+GqoVWApbR01eaf8c25NnxB4yCJTkg=; b=0+KOG0lpMeWaY2FdkBITG4q7rWbKWDei4m5pvkH6q2evV+0XFBTynaoyy89Va5E6A1 314Wd9xX5e11E+Z9DvEwEckmslPs5wQz+UdxYOZEVRGbPhUnoaTrcpPOk0+q+O0AQHSL pu+Hd7yH9g+7oHlAQbAKVU1V0hpb/B9aPF+sTtPdldHPkCWZ5QF5l4zBCkrS7kMqsL2G 9Y9MlCPC/Zt9VDR1Ya+ugYXnHI4Sny+QCqA1ChOjx6uUetwjlvUjeDhUkFLgfNDkThg9 yjVNw21fBQPEujvXDLuGR3rB/08Ib9qPFdWZYqUsSL8Ykgxv7Q19NnwVpCnfmV+1VctW 3XYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g87si16055097pfg.44.2019.04.23.01.09.48; Tue, 23 Apr 2019 01:10:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfDWIIb (ORCPT + 99 others); Tue, 23 Apr 2019 04:08:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26247 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfDWIIa (ORCPT ); Tue, 23 Apr 2019 04:08:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 494A63092667; Tue, 23 Apr 2019 08:08:30 +0000 (UTC) Received: from dhcp201-121.englab.pnq.redhat.com (unknown [10.65.16.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 762CB1001DC5; Tue, 23 Apr 2019 08:08:11 +0000 (UTC) From: Pankaj Gupta To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Cc: dan.j.williams@intel.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong.eric@gmail.com, pagupta@redhat.com, pbonzini@redhat.com, yuval.shaia@oracle.com, kilobyte@angband.pl Subject: [PATCH v6 6/6] xfs: disable map_sync for async flush Date: Tue, 23 Apr 2019 13:36:12 +0530 Message-Id: <20190423080612.15361-7-pagupta@redhat.com> In-Reply-To: <20190423080612.15361-1-pagupta@redhat.com> References: <20190423080612.15361-1-pagupta@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 23 Apr 2019 08:08:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta --- fs/xfs/xfs_file.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 1f2e2845eb76..0e59be018511 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1196,11 +1196,13 @@ xfs_file_mmap( struct file *filp, struct vm_area_struct *vma) { - /* - * We don't support synchronous mappings for non-DAX files. At least - * until someone comes with a sensible use case. + struct dax_device *dax_dev = xfs_find_daxdev_for_inode + (file_inode(filp)); + + /* We don't support synchronous mappings for non-DAX files and + * for DAX files if underneath dax_device is not synchronous. */ - if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC)) + if (!daxdev_mapping_supported(vma, dax_dev)) return -EOPNOTSUPP; file_accessed(filp); -- 2.20.1