Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3343895yba; Tue, 23 Apr 2019 02:02:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYyiiO5BwuiJA9thMuFKcF3A0Vd9vfybAdpc+hNyE+yYDZI/eIH9dQs8jEInft+V6KNKAZ X-Received: by 2002:a17:902:bc85:: with SMTP id bb5mr24999532plb.310.1556010149141; Tue, 23 Apr 2019 02:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556010149; cv=none; d=google.com; s=arc-20160816; b=vGbbTQEP6E8p2bEj7jl62UG8mlAl6ftw5LB95gNdSmXmBNDHyqrIaoVphBCHKek/JY RB96ldKTYHz8Ne0WNonawytcDJsHUXfZSocgLcAAlLjKZbHSPpxLQpW/gS9cuYzLCqf3 bdqh+oyl+p1njPMVkPvqu5i4tAKY7HH54lXjXm0xQ6d6NiTy9C5eb6co1X8sGhfLZX/Y 6WiBAh8Upfv9+CM7JwlNPK+lLl6LYRyrxhc+blUMMo4mPZO+PV3nX/1MDNGVi+FmY7/D iNqhfO+XwZC8ayFk+d9+uxK5IKvQIHa1oJTzzzlDk5732H7Cw5WbH2m5LdAXAXjxp57J RxQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XpySyR20DaPBZdkYkeoWcznu+aSI4vndXkWIKamHY6o=; b=PYj5M9W9NIvVv6oPLksP04cCtChmXG0rWlqmpJ8nS9AAFpDNRQF/1xKn8GEkewir7a mddk5D0+lS0JBB/ssIx+0WBCZf09vplOhlf3P/EdEtuuJzfmp0ykcyiXbZBRrym3W9F9 waKLIVlIFdF46OobuFkFc8tcrPrRn2UmP8H1TLSpAFotfkBlicvkMfwabBcrXTJXCj71 UyGLLXnw/xGE13uPiwi8exh8Touojz9qRtWey+1r9mxAEnp4R7MvurZQvrfTKyfhzYa1 4hw/+ApSSGuxwPiitPE2dgpBDHfdHU6OmKxUEqTwFYpvMOPqfUxwmDvdK92QZWj8kqbv KVdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MINSvgrn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si15472333ply.103.2019.04.23.02.02.13; Tue, 23 Apr 2019 02:02:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MINSvgrn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbfDWJAx (ORCPT + 99 others); Tue, 23 Apr 2019 05:00:53 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37169 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbfDWJAw (ORCPT ); Tue, 23 Apr 2019 05:00:52 -0400 Received: by mail-lj1-f193.google.com with SMTP id v13so206897ljk.4 for ; Tue, 23 Apr 2019 02:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XpySyR20DaPBZdkYkeoWcznu+aSI4vndXkWIKamHY6o=; b=MINSvgrn2eFsfQ6gMN9gIeu6w7NXRI3sUUDyL4Spi148j9unqYs3bsPY6sCKZS32l7 OsHai/KEk4Auxo8+lKuoKpVAR3xvNVnGdKpby1l1rFNADp+aOPYrwUSEi1B3pkVDuR0G JHkrkBM38eXHfrHlN0TkH2LVRquRN8ngsoPpNoa8dIcW0iVvhDGd1cE8gtokvU9t6mNV idrPFyYcykqUsnYXkA03fw2acebjzRO3YGRJZqUQAw4jF4qdMeieoPbHTtCh837K2lq5 4T1dY3iLWO1Syx7PF3WbLqN05AHHFXMMcm2Yjol2WBwexzRl4gcSKPqyqEuqXJnKDOia cQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XpySyR20DaPBZdkYkeoWcznu+aSI4vndXkWIKamHY6o=; b=hEmDAOtdt3e2E1hwDWkNzCwY7ux83G+2L80f/1iv4WQ8pd+GaL7G25m+ZB9MZ4m+h5 g+iTmQaDmpNaR7uRIxm3e4nqkhGIyd1R8K/caIoZkwZ6Gx5FA8gqa/1ri7wcFHBnhe5o qQvYyzviS9Z4aauRaOHIIi2VrwzjzKFkvpCnSdA9DN/707Fte2vNwhO8V6Mf3ftiIOtF UFU/b2wkNmH4fMw6+0AGVC4P1v1UBV7SsoUBh+yPMvTX4WnQKJCOqZ3nmjZ+9S2XAflp pujkG0TiAKezAjGoMzzZtTYSQJe9Sulo4XV7IS8QXw8Tj+Yxzj6Ybf5gapxfRnDtfOWU 3Lyg== X-Gm-Message-State: APjAAAUcumYRSrgCaJTZFT6z6YkXEt1HyO8B7m5JL2jfO/P12z7SPp9q 7YSAt0/ebqjQbiFP6RYbdLdVAlT+QK8Vu/SHokxqgg== X-Received: by 2002:a2e:8703:: with SMTP id m3mr12484258lji.107.1556010051211; Tue, 23 Apr 2019 02:00:51 -0700 (PDT) MIME-Version: 1.0 References: <1555048943-39589-1-git-send-email-wen.yang99@zte.com.cn> <1555048943-39589-5-git-send-email-wen.yang99@zte.com.cn> In-Reply-To: <1555048943-39589-5-git-send-email-wen.yang99@zte.com.cn> From: Linus Walleij Date: Tue, 23 Apr 2019 11:00:39 +0200 Message-ID: Subject: Re: [PATCH 4/5] pinctrl: samsung: fix leaked of_node references To: Wen Yang Cc: "linux-kernel@vger.kernel.org" , wang.yi59@zte.com.cn, Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Kukjin Kim , linux-samsung-soc , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 8:01 AM Wen Yang wrote: > The call to of_find_compatible_node returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:76:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:82:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Cc: Linus Walleij > Cc: Tomasz Figa > Cc: Krzysztof Kozlowski > Cc: Sylwester Nawrocki > Cc: Kukjin Kim > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Patch applied with Krzysztof's ACK. Yours, Linus Walleij