Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Stephen Boyd <sboyd@kernel.org>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] scripts/gdb: Add hlist utilities
Thread-Topic: [PATCH 1/3] scripts/gdb: Add hlist utilities
Thread-Index: AQHU+OUlC64SkSXBmEOwbSCd/Y19Cw==
Date:   Tue, 23 Apr 2019 09:20:47 +0000
Message-ID: <AM0PR04MB64346AE2641AACD732C2EF9EEE230@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <cover.1555921081.git.leonard.crestez@nxp.com>
 <aede2c05c333fd599252a74e67904ff7847b0dcf.1555921081.git.leonard.crestez@nxp.com>
 <155596568158.15276.10057207756258850078@swboyd.mtv.corp.google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 866f0e80-3d19-44cc-017d-08d6c7ccf877
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 09:20:47.3847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5235
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/22/2019 11:41 PM, Stephen Boyd wrote:=0A=
> Quoting Leonard Crestez (2019-04-22 01:26:56)=0A=
>> This allows easily examining kernel hlists in python.=0A=
>>=0A=
>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>=0A=
> =0A=
>> +def hlist_for_each_entry(head, gdbtype, member):=0A=
>> +    for node in hlist_for_each(head):=0A=
>> +        if node.type !=3D hlist_node.get_type().pointer():=0A=
>> +            raise TypeError("Type {} found. Expected struct hlist_head =
*."=0A=
> =0A=
> Maybe drop the full-stop? It looks weird to see struct list_head *.=0A=
=0A=
Makes sense, it was copy/pasted from list_for_each_entry. Since this =0A=
iterates over items from hlist_for_each the check is only useful as an=0A=
assertion anyway so I'll just drop it.=0A=
=0A=
The hlist_for_each/list_for_each raise gdb.GdbError on type mismatch; as =
=0A=
far as I understand the difference is that GdbError won't print a python =
=0A=
backtrace. However these are internal helpers so TypeError makes more sense=
.=0A=