Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3365929yba; Tue, 23 Apr 2019 02:30:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzFvAPXVlUWkDpWALNyunlzxTrVzIaemfm1QIGpeTkDVLsqZmvE4hz7PBE/cI53V55xpzX X-Received: by 2002:a63:ff05:: with SMTP id k5mr11164501pgi.342.1556011819837; Tue, 23 Apr 2019 02:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556011819; cv=none; d=google.com; s=arc-20160816; b=e6anZTQvY0pKNqUy9iGgFILqi+WNp8+g1FmCquw79xegUgCSsBm+tFzvcwM2UwqM9p eQVfmnyTvQKA72OzyV1PSUUfpwQ4WNta2EsjegI31CWaegZ8bCZ+eM6fSPOHCFxKL2Yn NIFPWFJF7E4xGUJtu1v/5HA6XB+/nVMzr7RfE8ZjugMikqhzpfsJ29e0qtD0cRvIJxkf tTChZs5iNWawTWFF1P0XFG/1LQmBli3+q1jnw9RcDBfJr6EJlZNjFaOJD83hJpdjOQ5Y cU+cVH9Aw8MaNJ3wz4qyud+VxM4XD1nibWaUizuWS9yVmL2eAQ7fjs13G1c3RtHB4zBN LWrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=w4fZiACkBLsuw5BLuZySw+S4JDknvGfC5Ei1Wz8auhg=; b=Wo2AWUuQRbl1mDvakGaKkGHEI97c7WESTrXnP55V1s7eSL6PYvOaFViA0eDpdBZwuK rlWpWuSUlRcrA3lNbGUb0wqmUSgtdCqrzKr6kR6dicmMEkB3IR7mhnO9+IUATfHPSHZG 4DCI4XcbjZF8+9FLbAy7DvOORLpnsR0LiKcQEOMjxNlyABNF9wArF84yWDvXium+VvC7 OWrnFoIXX0i6d2V60ll7Cx+6LqeH7ffLN95Fk9SWzIGDbWUhkPZ1pDYXn2Z/8d/VBmlR Sr4V6QrvmmG5CLztoJ0ZhyRx40LFEbAuBwKt+rOzhhYdPfseaNsBMAo4yR/ZNVF1xjBG VkXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b="twa/FD3W"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si2460939pge.484.2019.04.23.02.30.03; Tue, 23 Apr 2019 02:30:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b="twa/FD3W"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfDWJ3G (ORCPT + 99 others); Tue, 23 Apr 2019 05:29:06 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46721 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbfDWJ3F (ORCPT ); Tue, 23 Apr 2019 05:29:05 -0400 Received: by mail-pg1-f195.google.com with SMTP id v2so4886877pge.13 for ; Tue, 23 Apr 2019 02:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w4fZiACkBLsuw5BLuZySw+S4JDknvGfC5Ei1Wz8auhg=; b=twa/FD3WmOktH9MVUXb/BldyzAa94cTWq+B+S4ebxbShNY2tz68WlGR8/5ZjyL48Gh is1gLQKuXAdlVwuuYBQowMOWGgnIU4cLlahPNfTri8ya/Vkqg2xYHyMvm6kCa1JKUHHL DB0JMTZ3PHHGcuL1YReWXA8XA0zLfL56ZxME9SxJbU/ULv5oya+8sBH8pu35OH6ORWJe pC6g0alS54g3O2Ac9cY73AnwM9VJlHJmNtPofCIbswJQsGaT989Es/9OfoLnGhbBqSlj hgPxb/oKA/z6b0ax9JfOa6HYKAsuLpqd1NLUUS5jdBMs2GMG/HGXQQ4kumsm8D3hc1QN SA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w4fZiACkBLsuw5BLuZySw+S4JDknvGfC5Ei1Wz8auhg=; b=V8U1GrfMoqsz7ytmFLJonP5QKYkoe45WFiCc8hyvJ2SuGpv+OZM9pcNHO22tbSBEK6 gcZwdum1fu5qWpg+DuLwO9MGEU2eV1POybLifPjxlpKExABGWFHmkXSN2cq9rrt/F3Ei 3isSjDjkKUUrCJsNlY6O8dMogMkQY3JOiZCJfY5J2OrqolxR5FjLF3vaMbzB/Hpsumz2 Vafr+7NUdW8YJMLW+htSNBaDb3qSv2aiK013bLO5KqBx7w1bwkwkwWEBYnT5f4U++ZTK xBPP7eK4sMclvaBsGmrTjBqJYpe80akjjggJu+hkIvgFzAnM8piC/1OWCCul+I9gl/fi DIwg== X-Gm-Message-State: APjAAAX3N9IHYDzBpPB1IUcOWWqF+jvLg9BQ3ISFwyFCYErW6cozNANH H+BSFCblTF8dCnhh0JRDFtVe7A== X-Received: by 2002:a63:1d26:: with SMTP id d38mr22898103pgd.357.1556011744623; Tue, 23 Apr 2019 02:29:04 -0700 (PDT) Received: from localhost.localdomain (123-204-46-122.static.seed.net.tw. [123.204.46.122]) by smtp.gmail.com with ESMTPSA id q10sm18905809pgh.93.2019.04.23.02.29.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 02:29:04 -0700 (PDT) From: Jian-Hong Pan To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux@endlessm.com, Daniel Drake , Jian-Hong Pan Subject: [PATCH] i915: disable framebuffer compression on GeminiLake Date: Tue, 23 Apr 2019 17:28:10 +0800 Message-Id: <20190423092810.28359-1-jian-hong@endlessm.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Drake On many (all?) the Gemini Lake systems we work with, there is frequent momentary graphical corruption at the top of the screen, and it seems that disabling framebuffer compression can avoid this. The ticket was reported 6 months ago and has already affected a multitude of users, without any real progress being made. So, lets disable framebuffer compression on GeminiLake until a solution is found. Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085 Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 656e684e7c9a..fc018f3f53a1 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1278,6 +1278,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) if (!HAS_FBC(dev_priv)) return 0; + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ + if (IS_GEMINILAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1; -- 2.21.0