Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3367833yba; Tue, 23 Apr 2019 02:32:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwynmCBXY6l7qfSGq7JXDu7H19bztIJxQwXgwWqShgLbg2EMjgXtU9Uj3FA29BLI6ANkC+l X-Received: by 2002:a17:902:396a:: with SMTP id e39mr25092279plg.220.1556011954099; Tue, 23 Apr 2019 02:32:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556011954; cv=none; d=google.com; s=arc-20160816; b=vOxmWOi+lBcmIGEYCS8eMAMNJNK7iKpOVXX0fjov6CrtUp4B5xLJwrvWCjzdua58Ki FOm2gcrmsk+UgIWMXveZav8cF3DqlFQPXIWR7vwmqPK5IhXQufCpgnQnJNf/2FEFdYHC dXeQmVVciQ9kHRJre8+oa+8IxLpdYaTGcj/ujCLq0NV9YtizTEN3HTrfBTLJ8VFKVnJm rBZY3AGECrIcO1pB2sntlFyjcwTCH7qBtbGaZN24PHXrEA9ALSHFuQo4kuoi8FeQQ+d5 /cT1RNvwA7kfMFhiiRT8XEP2Gtbu6hcn1N5KUgkWxz6GmiP+ZE3OyIbAnuJaDOVt/puU LQbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=QSM9OziZYstBOOE9wa5c+jKbo80Kv/E23e1GaJb4hq8=; b=bPcvm7BgoekwuOkkYFMHPdHCA8cqKiLrDK8xDK1wb48LgHMl2JKTZPdVXcyoLPus96 3GrTHHW6dovG4/LK1UqurGkdAg5KgCFCyp1Ihv0s/lFMi/tiCl0uJ68NPJ+PRU6CurYB /XB6vMhS/DSjQ4XXnp0/kS+syLJmlxJkCvemHLyBv5NIpEmfKDZo0UB3UQYzr6sP0zD1 9d21ybB7LHaVbPCLeyBubMR52umf1o1D9y/x34g+r2saFpAxzmbdxJqm8PUgi/76Z2cj woGanjTtcqJNlExYA5lP4hKbuhZxh3pOJR2MsuVB1nrw5dyPavV2hY3UMOqjygDpgver 9ytw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si15765782pfr.246.2019.04.23.02.32.18; Tue, 23 Apr 2019 02:32:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbfDWJbV (ORCPT + 99 others); Tue, 23 Apr 2019 05:31:21 -0400 Received: from ns.iliad.fr ([212.27.33.1]:33192 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfDWJbV (ORCPT ); Tue, 23 Apr 2019 05:31:21 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 980E3209D4; Tue, 23 Apr 2019 11:31:19 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 7F55C20948; Tue, 23 Apr 2019 11:31:19 +0200 (CEST) Subject: Re: [PATCH v2 00/13] qcom: dts: thermal cleanups To: Amit Kucheria , Andy Gross Cc: LKML , MSM , Bjorn Andersson , Sibi Sankar References: <5583cae1-8fea-724a-24a4-59b38a205ac3@free.fr> From: Marc Gonzalez Message-ID: <842b06c6-15b2-7ba6-702e-c8b043d390a6@free.fr> Date: Tue, 23 Apr 2019 11:31:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Tue Apr 23 11:31:19 2019 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04/2019 20:46, Amit Kucheria wrote: > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: >> >> On 29/03/2019 11:12, Amit Kucheria wrote: >> >>> Changes since v1: >>> - Devices that are not associated with cooling-maps use the 'hot' type >>> - Remove critical trip from such devices too and restrict that type of CPUs >>> - For 8916, add the sensor on the modem >>> >>> Description: >>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845 >>> - split up the register address map for msm8998 >>> - standardize names of the various thermal-zones across boards to make it >>> easy for test scripts to parse >> >> This is what I see on msm8998 with your patch series applied on top of >> yesterday's next: >> >> # dmesg | grep of_parse_thermal_zones >> of_parse_thermal_zones: build cpu0-thermal zone 0 >> of_parse_thermal_zones: build cpu1-thermal zone 0 >> of_parse_thermal_zones: build cpu2-thermal zone 0 >> of_parse_thermal_zones: build cpu3-thermal zone 0 >> of_parse_thermal_zones: build cpu4-thermal zone 0 >> of_parse_thermal_zones: build cpu5-thermal zone 0 >> of_parse_thermal_zones: build cpu6-thermal zone 0 >> of_parse_thermal_zones: build cpu7-thermal zone 0 >> of_parse_thermal_zones: build gpu-thermal-bottom zone 0 >> of_parse_thermal_zones: build gpu-thermal-top zone 0 >> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22 >> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22 >> of_parse_thermal_zones: build cluster1-l2-thermal zone 0 >> of_parse_thermal_zones: build modem-thermal zone 0 >> of_parse_thermal_zones: build mem-thermal zone 0 >> of_parse_thermal_zones: build wlan-thermal zone 0 >> of_parse_thermal_zones: build q6-dsp-thermal zone 0 >> of_parse_thermal_zones: build camera-thermal zone 0 >> of_parse_thermal_zones: build multimedia-thermal zone 0 >> of_parse_thermal_zones: build pm8998 zone 0 >> of_parse_thermal_zones: build battery-thermal zone 0 >> of_parse_thermal_zones: build skin-thermal zone 0 >> >> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal >> >> >> # cat /sys/devices/virtual/thermal/thermal_zone*/temp >> 35800 >> 35200 >> 34500 >> 34800 >> 34500 >> 34100 >> 34100 >> 33500 >> 33800 >> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument >> 36100 >> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument >> 35500 >> 36100 >> 35800 >> 35200 >> 35500 >> 36100 >> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument >> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument >> >> >> Are the failures expected? >> (cluster*-mhm-thermal and thermal_zone*/temp) > > No they are not. Unfortunately, I didn't have HW to test, so > appreciate the help with testing. I'll check the 8, 9, 17 and 19 again > before resubmitting. Looks like Andy merged this series? https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next I was expecting a respin, or a discussion of the failures. Slightly confused. What next? Regards.