Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3380471yba; Tue, 23 Apr 2019 02:48:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwe8lfkZOdIWtzuLyDooip6dtk2qeqQ/qg2xIyFpjKk9hI7ycRnauSHDkOLPND4/lIsIQ3q X-Received: by 2002:a63:c10e:: with SMTP id w14mr4203867pgf.206.1556012924489; Tue, 23 Apr 2019 02:48:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556012924; cv=none; d=google.com; s=arc-20160816; b=KqG53BYQ+dysT+GvZ0CbU9gleF4M+mfJgqLR5jdMO2aa9UvavjbsXNGCG0/fEc9sjh PRHqq3+wtbXxLq7dXFBFZKb9uC/uDPh+V8SRXL4ZzSDih0k46Y5R9MOwhk1gl2FLXvQC r6CbR/zu8dvFSku/dTSQW5lfTloTTXJmyUSlCnYgvqw9BywkLYSuyiZygyqIffvsVCpp 8nbO8JgSW6+KhW8RBAW9FNlZd3VGG1pre/DK9Buf3mLYvxmx+CnBor0cs8s6vicsuRID LFVnM1kWNmoabwwlglw43r+VZxdFeSgTqY+4khFUxqI6stjzYYBAhDRAMQ6dufVwNmIC DU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZG2dlcWtNNZxXUbPH3bRjuZncLwEfGlDXtch5CgLX/Q=; b=HqMbSXGAGkTte2PcdgCswutfOLpa5K6/VkG4WhIRhMgMbbApoL/4Af0KKwp0CIEZYW NkHZkLnazUfZG1RE02EPoI+4DcKuD1js+5AgfvS1sXHTQ8ydYztSgNR5nxB440of1QtG vcLtQ81IXV8UTJauKrfDrDeyfk7QoYZJUJWX/Co0hq6VYwC+mWLoXRRUCPYiEQrpQQi6 IozqkTcKoE5fiF6sr8Y2GT4LNSP6MlZbn+lg9vlcf3fXkJEcCVorZbsxY80FWZ1zsyC4 YwOhxNLRF/GUOBki5TqCaXHs2YphtOOJ2XK+7fWQhDuVxzqDAe/Ozy+sJ2g8eeEePT9Q 7Psg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=ugxlEb4s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i96si15956207plb.331.2019.04.23.02.48.29; Tue, 23 Apr 2019 02:48:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=ugxlEb4s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbfDWJrA (ORCPT + 99 others); Tue, 23 Apr 2019 05:47:00 -0400 Received: from merlin.infradead.org ([205.233.59.134]:47128 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbfDWJrA (ORCPT ); Tue, 23 Apr 2019 05:47:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZG2dlcWtNNZxXUbPH3bRjuZncLwEfGlDXtch5CgLX/Q=; b=ugxlEb4sjNIY7tZ9fUhvPMHXXL dXph+KhM7zeyt15QyBaGwE6z3hplR611VfhoWEnpYrCFyeVwt1CiJmkU+ZUgYpUBZBzZ8xMkVC0Bd Cuyt2hcODWc7MePUpOEx04npM6xiW5Og/Xg5BSH1pv/xvWluPRm78OoWtdweWgAW/yQhlacPCsy2+ /GS59LBtvC680KFoiyN8Kwx9tGyCZUf1UbSteH7UUMaH/N+HDON84XC/sY+qJy4polvo72cGFRit+ tzpzGj1CDVDCE0N31jhJRk7yVvsrJ0Qx5cEawHUkBckIXuiK6VwoVEzSMxwlIZ1cXO2WXNPcoQA02 PDecM9Zw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIs0j-00020N-RA; Tue, 23 Apr 2019 09:46:46 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9A37A29BF8E8B; Tue, 23 Apr 2019 11:46:44 +0200 (CEST) Date: Tue, 23 Apr 2019 11:46:44 +0200 From: Peter Zijlstra To: =?utf-8?B?546L6LSH?= Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 2/5] numa: append per-node execution info in memory.numa_stat Message-ID: <20190423094644.GL11158@hirez.programming.kicks-ass.net> References: <209d247e-c1b2-3235-2722-dd7c1f896483@linux.alibaba.com> <7be82809-79d3-f6a1-dfe8-dd14d2b35219@linux.alibaba.com> <20190423085248.GE11158@hirez.programming.kicks-ass.net> <8c3ad96d-7f3d-d966-6acc-8327023ae3f9@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c3ad96d-7f3d-d966-6acc-8327023ae3f9@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 23, 2019 at 05:36:25PM +0800, 王贇 wrote: > > > On 2019/4/23 下午4:52, Peter Zijlstra wrote: > > On Mon, Apr 22, 2019 at 10:12:20AM +0800, 王贇 wrote: > >> This patch introduced numa execution information, to imply the numa > >> efficiency. > >> > >> By doing 'cat /sys/fs/cgroup/memory/CGROUP_PATH/memory.numa_stat', we > >> see new output line heading with 'exectime', like: > >> > >> exectime 24399843 27865444 > >> > >> which means the tasks of this cgroup executed 24399843 ticks on node 0, > >> and 27865444 ticks on node 1. > > > > I think we stopped reporting time in HZ to userspace a long long time > > ago. Please don't do that. > > Ah I see, let's make it us maybe? ms might be best I think.