Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3416010yba; Tue, 23 Apr 2019 03:29:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMCIy8hyaFqWpTAaW9woUEJFi3mSP3ZpD0vYXgj/s9Keo2w2FiakGhXDcJB6nG/O9QNEGn X-Received: by 2002:a17:902:e48c:: with SMTP id cj12mr24639932plb.93.1556015377575; Tue, 23 Apr 2019 03:29:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556015377; cv=none; d=google.com; s=arc-20160816; b=wRD7jPiFmp3K+YDR2NE2Arso8Cpu0+1z4iP9PyCt8WgayrMZuWH1cSZ33q38coSyl5 21GCyAJw7wZeVm4ik+eDUJSL9XbE/opb9iyIvq8nM3kqO+171bm561UlCELLhCE6LVY9 YNFBYOdksCFSV0jVzJCta2z8mvHvxfROTBikoKWc6KlNz8YodqsFrydZbUnPl18abUrf vbDUsDm+16tKf4qoMs65fk5h7u9u0ZhDC81lRD0UaJKE4KvRQBnJwhF6tuPQVNLjiJSE UGgmipK7/pf9x2T8Xk+ruIw1CMRfP3ieMIwEfQBIZf+IoC6lD2LU0be/eJSDSPBe+pZk zMZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=BRobltQiP5Dfzmo7e5ElfARUNAtjNwSKM5rnNZDq4uVFoFYUOKbYxttscj0LzDUpti Thh2aLpwCVVP6iwufpCgOi6tUBt83RY/YvgXGLekTyHONQud6PfbEayZkCtUQOPJtzDi bCoWR04zuvnh0n28pmqW9Wtel71dM8gPA2opp0btx30vm7vd7BallXfS0mdHrNCUQCSc gezRmEbqzOdC9RMEYrgautNMev3byYFN2ZqyW3S9PtHMusNwTNO+FEV273gnIxqvqu9y 79XxK7QOejTQgW6khpEowRSfKMYTQKSjZG9OZNmInfxBFJvIUnPo7bYYh1uFVLCvt4je LbCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R71P1EHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f64si15976836pfc.168.2019.04.23.03.29.22; Tue, 23 Apr 2019 03:29:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R71P1EHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727397AbfDWK0y (ORCPT + 99 others); Tue, 23 Apr 2019 06:26:54 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37542 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfDWK0x (ORCPT ); Tue, 23 Apr 2019 06:26:53 -0400 Received: by mail-lj1-f194.google.com with SMTP id v13so437841ljk.4 for ; Tue, 23 Apr 2019 03:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=R71P1EHtE9ho7Q7VaICQcQfxwqZxvTIIoMzw3gql1mrrGGSUukyBT6JAymY6q8nFRd AekCHr6FRxyNKtmnj0b52GWN93roohjUvmdUEtBMNtd9SPDv0Rl+CZG2qkK/Qdq3pLpq ILNlgEgewBdvOZNx7LJOdRl3+AVEc9fshal3/fcJ1X0gULtD+QaQOY5gFTe6UDWCSgny Q2ezjf0z6XsHHW2lw18lwGk5LOwsaZR6UK9YG/g6VZl0g+9NHWEvBJjwJAOPzWuUBska JooQNKqfWDYfBDjNJVkQl3RpxYhJ6fATqku8Ay5l0YwG/tVUBKgc8Tc6uu9nlnXdLkL2 2Wjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=ulwd4jozBxHkQ9IysmrbCNdZBZpsSZJj05h3DkqYzzhOOsoTARUCcU+w2MPM4RrjS+ g+ASw5cxaB7q0ux+CFGxdkr8aAXgzho9WhK0z3gWvG5D5kxOLJ/w09bTEqYsheOWoBYI 2m+X/kG0RXdnSVGOHbYVJCxY5VWLdy+coya5Q56EYxN2IEq6zzumt7uWEJcpR8xAfHDV 0HYd2xpT2192+OgJ60MklyX9jt5uzt26yfQsOEVd4ea93WnGXAh3ug04+7rPRIJyYPzG LhYkGbyh0Zh4Qznh5drjN5vykE+0PRIllPQdL5qzxPIXgsyZRY7FHcWaEmLVW5tWhipg ESYA== X-Gm-Message-State: APjAAAVPcZo8usut+pnnwJrevJazwQeBCOBM8rGMTZ7GGYY/k4Y/crbW rBOSZGZghbJm/Stxi09ElIASNaHzA47wnkcqrpcMdQ== X-Received: by 2002:a2e:8703:: with SMTP id m3mr12709901lji.107.1556015211519; Tue, 23 Apr 2019 03:26:51 -0700 (PDT) MIME-Version: 1.0 References: <1555139666-948-1-git-send-email-hofrat@osadl.org> <1555139666-948-9-git-send-email-hofrat@osadl.org> In-Reply-To: <1555139666-948-9-git-send-email-hofrat@osadl.org> From: Linus Walleij Date: Tue, 23 Apr 2019 12:26:40 +0200 Message-ID: Subject: Re: [PATCH] ARM: u300: add missing check for kmalloc To: Nicholas Mc Guire Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mark Brown , Tony Lindgren , Mike Rapoport , Janusz Krzysztofik , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicholas, thanks for your patch! On Sat, Apr 13, 2019 at 9:20 AM Nicholas Mc Guire wrote: > kmalloc return for bigrxbuf_virtual was not being checked - in case > of failure set status, cleanup bigtxbuf_virtual and baile out. > > Signed-off-by: Nicholas Mc Guire > Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") This code is deleted from the kernel and the code had zero users before that, so no need to fix it! Sorry for your trouble! Yours, Linus Walleij