Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Stephen Boyd <sboyd@kernel.org>
CC:     Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] scripts/gdb: Add $lx_clk_core_lookup function
Thread-Topic: [PATCH 3/3] scripts/gdb: Add $lx_clk_core_lookup function
Thread-Index: AQHU+OUmSMastDjNC0mx+PohUrHy2g==
Date:   Tue, 23 Apr 2019 11:12:49 +0000
Message-ID: <AM0PR04MB6434A133CB5ABA0286B0F487EE230@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <cover.1555921081.git.leonard.crestez@nxp.com>
 <ebda22b2d3f7e35db5809bf21f4f9ee3ac38f5d9.1555921081.git.leonard.crestez@nxp.com>
 <155596430227.15276.13435242792506854365@swboyd.mtv.corp.google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a0670d77-d2bd-4ce3-7f68-08d6c7dc9f39
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 11:12:49.6371
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4564
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/22/2019 11:18 PM, Stephen Boyd wrote:=0A=
> Quoting Leonard Crestez (2019-04-22 01:26:57)=0A=
>> diff --git a/scripts/gdb/linux/clk.py b/scripts/gdb/linux/clk.py=0A=
>> +class LxClkCoreLookup(gdb.Function):=0A=
>> +    """Find struct clk_core by name"""=0A=
>> +=0A=
>> +    def __init__(self):=0A=
>> +        super(LxClkCoreLookup, self).__init__("lx_clk_core_lookup")=0A=
>> +=0A=
>> +    def lookup_hlist(self, hlist_head, name):=0A=
>> +        for child in clk_core_for_each_child(hlist_head):=0A=
>> +            if child['name'].string() =3D=3D name:=0A=
> =0A=
> Do you need to do the .string() for comparison? Or does it work just as=
=0A=
> well to compare a gdb.Value object to a python string? It would be nice=
=0A=
> if the gdb.Value object could figure out that they're not both gdb.Value=
=0A=
> objects so it can do a string comparison itself.=0A=
=0A=
The gdb manual is not clear on how comparisons work on gdb.Value types. =0A=
Converting to a python string and comparing in python work well, using =0A=
=3D=3D on string gdb.Values results in this:=0A=
=0A=
     gdb.error: evaluation of this expression requires the program to =0A=
have a function "malloc"=0A=
=0A=
My guess is gdb attempts to convert both arguments to gdb.Value and do =0A=
the comparison via a call on the target? This is very undesirable here.=0A=
=0A=
I get the same error if "name" is a gdb.Value instead of being converted =
=0A=
to a string in invoke().=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=