Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3456280yba; Tue, 23 Apr 2019 04:15:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUse5kdFN7yRDelNtPnZ9i5OWUztJlwk8tSrCeaMPiGZXlvKL723ivwoGTVBeTCexrjPN9 X-Received: by 2002:a17:902:848d:: with SMTP id c13mr967143plo.279.1556018151958; Tue, 23 Apr 2019 04:15:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556018151; cv=none; d=google.com; s=arc-20160816; b=TH34X+8MQbu1ytMGQK1ZEJ77cBiHyyRgxNCLPlXcXCaywCCLYLvgGNV9naF8WDbJeq 8r4+Ey3ag8PSOXZtmUEGUwyljSu3UMinR1lN0N/1yehcqESpoMauLqieftvDJLJjkUfg xvNOBxD/uhfbsy47Ze5Tnip8SF1Ju6cYukxTbb75HB2OucV0sZkILpi28dyKDszpRZL8 XxJQBHZobFSHZWvtY1PIdJ5ojelLF4/3iHCTo10UQYBHgG40LA88MozDqnRJmTof91jl wlz43aB2oHWmRwt7Ojd3lik2Uch1cEAt5ic9Rqf63xaygDIFsmmXypyeGAKXK1lMCLX6 mcrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9ZdAYYTQTE6CwxicfOwg//XFX9eyEJGiAoUEgu4DC8Y=; b=nJ3InoHr+odyFtNzOo5KWHcpq804oRlb3tYQh+BKXHVYkYqOPyx/ydoVtPvM9TPg// xF7lF4lmZ/fJp3b4xVRWq5yhcoOy1gcrADm/t+2H0qhSEJ4HZ++/EAqqByh3Wj1hNhRw 4mib7MtWW3CX0NsnO2p8zKjsBs6GqNG2lz56QZmcfGEEBxueqU/DBYFb+g8fvfti1NZ5 GRBNnLlIML3h6mQmuefTxQqVwsF2e2A+bzeet3hgHIWGQJW2IW0n0wnD7K5R8xL9G+0K g/bDOIJo3oh8YC3eU6SOXTxyfsPBDDdIz64zJyCdYp9r4DU/ZeS3Im4tX482K7Q453Qc Ajug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L0DGpMKM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6si5050450pgj.225.2019.04.23.04.15.36; Tue, 23 Apr 2019 04:15:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L0DGpMKM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbfDWLOk (ORCPT + 99 others); Tue, 23 Apr 2019 07:14:40 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:44024 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726655AbfDWLOk (ORCPT ); Tue, 23 Apr 2019 07:14:40 -0400 Received: by mail-lf1-f67.google.com with SMTP id i68so11416169lfi.10; Tue, 23 Apr 2019 04:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9ZdAYYTQTE6CwxicfOwg//XFX9eyEJGiAoUEgu4DC8Y=; b=L0DGpMKM6Z16Ym1N/bwzrtCFgJ3XEJyF6CP+VYK9ZFjAW4m5Jnt/rlqA+1B1NWONqI BeZJlgxfKjsM9/rkm0fo9kyIS4LRm4fKAteEEKtnLXxFquXKQtOpt2DUb0oyzBitOMJR INP3rtAztLw4swqP0D8bV9rsdUu4/qIcGu3OGrqCxWEDflbstkjhvl3Mr/Mo7y7C49CR 1OLkmZ4BogmJ4Yatt0yENzoqeWGPMkUFfToMwieIQNiKgn8VxaIYNbqWfI2VlceGKdqJ mReJPaWLs1WBSrtIS1TIxsvoovxaIcebaCbNygzR4QHYlKz1cEgeBUPHNKMiPcKIFdft 3Lsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9ZdAYYTQTE6CwxicfOwg//XFX9eyEJGiAoUEgu4DC8Y=; b=dxXNFmZHMlA/ECMTLu04LZWNv8OA1+mCOo4kCK+eVBdTLnHkNX2w/YDB3Z9RdTnwJs Ydp1mG6/J/+tPrsO8Spk55CAjIP8pPjydIdPQ+OaZNHti89x/qNnzs72dOrCzT1zJixW ZhwpND4z7sAzDbcECtiUO2G8AGOlmPrs4q6Q4fzxxWLtJB/1jPHsOLNkBtjRqdcvz/G8 2gkUGK2T+q5IIP3JwP+rzYJLWlbRytRmcTHGm939GShD9CI092ZcbaqTn6sZhHpEjs2l tiMyvwgbc4uZKxnDba29hOVQ34VDBmFX7lf1DnTLXzhogocvTHftHwU5FX1ygDYA8CS1 UU2A== X-Gm-Message-State: APjAAAUXMdqxrymrGaKabIRU2P8K+zcyoy7uZvawKZXnxbla1hFIt+W/ BOT2yqIpjhMX0IDI1aSjr4gG98gmB3nSRnDOLCm6nT9k X-Received: by 2002:a19:f001:: with SMTP id p1mr14429836lfc.27.1556018077647; Tue, 23 Apr 2019 04:14:37 -0700 (PDT) MIME-Version: 1.0 References: <20190423104649.24483-1-xiaoning.wang@nxp.com> <20190423104649.24483-2-xiaoning.wang@nxp.com> In-Reply-To: <20190423104649.24483-2-xiaoning.wang@nxp.com> From: Fabio Estevam Date: Tue, 23 Apr 2019 08:14:35 -0300 Message-ID: Subject: Re: [PATCH 1/3] spi: lpspi: add NULL check when probe device To: Clark Wang Cc: "broonie@kernel.org" , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clark, On Tue, Apr 23, 2019 at 7:47 AM Clark Wang wrote: > > Add a NULL check for device node and lpspi_platform_info when lpspi > device probe. Please explain why you are adding such check.