Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 23 Apr 2019 16:56:01 +0200
From:   Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC:     <linux-kernel@vger.kernel.org>, Juergen Gross <jgross@suse.com>,
        <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v2 1/2] xen/pvh: set xen_domain_type to HVM
 in xen_pvh_init
Message-ID: <20190423145601.7qwu63sz2ycg5ywj@Air-de-Roger>
References: <20190423130416.68935-1-roger.pau@citrix.com>
 <c2e1612e-d6c2-ba46-b49e-4e0fe95a1d7e@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c2e1612e-d6c2-ba46-b49e-4e0fe95a1d7e@oracle.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 23, 2019 at 09:37:51AM -0400, Boris Ostrovsky wrote:
> On 4/23/19 9:04 AM, Roger Pau Monne wrote:
> > Or else xen_domain() returns false despite xen_pvh being set.
> 
> Is this new xen_domain() invocation somewhere in EFI initialization that
> you add in the second patch?

Yes, there's a xen_initial_domain() call in xen_efi_probe() which
would return false without this fix.

> Asking because I am trying to figure out whether this needs to go to
> stable tree.

I'm not aware of this being an issue without the EFI code that I add
in patch 2, xen_domain_type would get set slightly later in the boot
process.

I guess both patches should be backported to 4.19 since that's the
only LTS release that has PVH dom0 support IIRC, and it would be good
to get this fixed.

Thanks, Roger.