Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1553677194.git.kirr@nexedi.com> <d916d401a80e9834c95970d86ca71c0154e988a6.1553677194.git.kirr@nexedi.com>
In-Reply-To: <d916d401a80e9834c95970d86ca71c0154e988a6.1553677194.git.kirr@nexedi.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Tue, 23 Apr 2019 16:57:58 +0200
Message-ID: <CAJfpegt9DRmwKksR0QSA7NzQP_=a=yJybdL9mOP1cw5goGkdgw@mail.gmail.com>
Subject: Re: [RESEND1, PATCH 1/2] fuse: convert printk -> pr_*
To:     Kirill Smelkov <kirr@nexedi.com>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        Brian Foster <bfoster@redhat.com>,
        Maxim Patlasov <mpatlasov@parallels.com>,
        Anatol Pomozov <anatol.pomozov@gmail.com>,
        Pavel Emelyanov <xemul@openvz.org>,
        Andrew Gallagher <andrewjcg@fb.com>,
        "Anand V . Avati" <avati@redhat.com>,
        Alexey Kuznetsov <kuznet@virtuozzo.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        Constantine Shulyupin <const@makelinux.com>,
        Chad Austin <chadaustin@fb.com>,
        Dan Schatzberg <dschatzberg@fb.com>,
        linux-fsdevel@vger.kernel.org,
        fuse-devel <fuse-devel@lists.sourceforge.net>,
        linux-kernel@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 27, 2019 at 10:15 AM Kirill Smelkov <kirr@nexedi.com> wrote:
>
> Functions, like pr_err, are a more modern variant of printing compared to
> printk. They could be used to denoise sources by using needed level in
> the print function name, and by automatically inserting per-driver /
> function / ... print prefix as defined by pr_fmt macro. pr_* are also
> said to be used in Documentation/process/coding-style.rst and more
> recent code - for example overlayfs - uses them instead of printk.
>
> Convert CUSE and FUSE to use the new pr_* functions.
>
> CUSE output stays completely unchanged, while FUSE output is amended a
> bit for "trying to steal weird page" warning - the second line now comes
> also with "fuse:" prefix. I hope it is ok.

Yep.  Applied, thanks.

Miklos