Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3892980yba; Tue, 23 Apr 2019 11:18:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7nJAmtmT4FROzrSOwFwm1bQKANXdPd9Sv4jHxyLeEcbtizmz6iUsitXKLnsNrbES79m1Y X-Received: by 2002:a63:c706:: with SMTP id n6mr26083730pgg.310.1556043497613; Tue, 23 Apr 2019 11:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556043497; cv=none; d=google.com; s=arc-20160816; b=SGIwDYTmUA4BSfJ6fGDUOxJZj/kOXUil2gHQzv0GnVATvt6SlEcqraIiGm0zsF2Pse nSEBSPszHzeu05FJoHR6pwimmkJ1kF/CB3cGAMavrc4k1pwz2tP7CiC/3YO/KyluO36/ +IgGaZu8sqOhD/GirpgHs2SXbl5hBxhiq/08dsFQ0AGr6rmAXuok7zJOiChQbDcmBZ9r bQAAxI8Ien/DcIZCgsYZEe9FHHl/wKXex14TQSeTtB4AIWO5NwCNF3P4AaH9ObHT+tq6 8hH4D6IWOz8PgugIyxmZEgoXxdl6DvVIQRNtpBSsuUW+ZtH500XWbMY4pq6iuBjwQfHJ mAGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:message-id:to:subject :from:cc:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=YljXfoCwUZAtZoueDx3Unr5c6Dc+6+x52cxG46GyVww=; b=wsO4evJCrTuxlFenkh4gyVd+JPut3xRFKjLw7EjmgtVZgSADkxmx5yPu0swE6FaTbi DWpI0D+Jf1ZSG1j22dnBgDm2q1pzpO2VbqWOYzwl9XipvI8a2VdnmY7vSa4/xrSGmF/Q 807cT/H+c60OvUxNHUO66qK3PPzEnGZENNGIeHcd30Pe74gN5Yps7XmMMFGNOA57PKPw NxsZppdLmaFmhnuUjCi4E+FSyqHOB5hhOUxuNHsO0MsyckghTSgDIdvf+SQvkepZsmHZ wH8JCTiSPbgOP8OhlAAADNCiPK4n3zaU8HF94YYvLqb14A2VLvO2ALhUnhbNL9CjeEZH QBFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0WGhAnI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o23si15232400pgv.540.2019.04.23.11.18.03; Tue, 23 Apr 2019 11:18:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0WGhAnI4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726274AbfDWSQb (ORCPT + 99 others); Tue, 23 Apr 2019 14:16:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbfDWSQb (ORCPT ); Tue, 23 Apr 2019 14:16:31 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5431208E4; Tue, 23 Apr 2019 18:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556043390; bh=g0IVXqa/Y4i5aAaYke9vj3+8qJZw9M2R/F0j9joHvQ0=; h=In-Reply-To:References:Cc:From:Subject:To:Date:From; b=0WGhAnI4qbWAmbYe/wXR3JQSWCnuRxoq/wmROI0Gjw3ucPMHVfQ7n8zaxn5xEKHjD tSssSyOT72htChQYZEw9VFSoLLkcg6Y/BRaS3kkfILRdihkGCCkebf43GmJbwpKo6Z gV2C+gYJW8UH5YZqJ11jFRLQMBi+qXI/6nBfD5pw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <155596430227.15276.13435242792506854365@swboyd.mtv.corp.google.com> Cc: Jan Kiszka , Kieran Bingham , "linux-kernel@vger.kernel.org" , Andrew Morton From: Stephen Boyd Subject: Re: [PATCH 3/3] scripts/gdb: Add $lx_clk_core_lookup function To: Leonard Crestez Message-ID: <155604339005.15276.3433915905558978655@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Tue, 23 Apr 2019 11:16:30 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Leonard Crestez (2019-04-23 04:12:49) > On 4/22/2019 11:18 PM, Stephen Boyd wrote: > > Do you need to do the .string() for comparison? Or does it work just as > > well to compare a gdb.Value object to a python string? It would be nice > > if the gdb.Value object could figure out that they're not both gdb.Value > > objects so it can do a string comparison itself. >=20 > The gdb manual is not clear on how comparisons work on gdb.Value types.=20 > Converting to a python string and comparing in python work well, using=20 > =3D=3D on string gdb.Values results in this: >=20 > gdb.error: evaluation of this expression requires the program to=20 > have a function "malloc" >=20 > My guess is gdb attempts to convert both arguments to gdb.Value and do=20 > the comparison via a call on the target? This is very undesirable here. >=20 > I get the same error if "name" is a gdb.Value instead of being converted = > to a string in invoke(). >=20 Ok. Thanks for checking. It might be worth filing a bug with gdb to see if this can be improved in the future.