Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190306201413.14153-1-tycho@tycho.ws>
In-Reply-To: <20190306201413.14153-1-tycho@tycho.ws>
From:   Kees Cook <keescook@chromium.org>
Date:   Tue, 23 Apr 2019 15:11:03 -0700
Message-ID: <CAGXu5jJDhQ_3jS9-VSUwruFDpb4GwqUs=iz7uNGMkPbLnNWKUw@mail.gmail.com>
Subject: Re: [PATCH 1/2] seccomp: fix up grammar in comment
To:     Tycho Andersen <tycho@tycho.ws>, James Morris <jmorris@namei.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 6, 2019 at 12:14 PM Tycho Andersen <tycho@tycho.ws> wrote:
>
> This sentence is kind of a train wreck anyway, but at least dropping the
> extra pronoun helps somewhat.
>
> Signed-off-by: Tycho Andersen <tycho@tycho.ws>

Acked-by: Kees Cook <keescook@chromium.org>

James, this can go in for v5.2 -- no rush.

-Kees

> ---
>  kernel/seccomp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index e815781ed751..d0d355ded2f4 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -329,7 +329,7 @@ static int is_ancestor(struct seccomp_filter *parent,
>   * Expects sighand and cred_guard_mutex locks to be held.
>   *
>   * Returns 0 on success, -ve on error, or the pid of a thread which was
> - * either not in the correct seccomp mode or it did not have an ancestral
> + * either not in the correct seccomp mode or did not have an ancestral
>   * seccomp filter.
>   */
>  static inline pid_t seccomp_can_sync_threads(void)
> --
> 2.19.1
>


-- 
Kees Cook