Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1553954142-65515-1-git-send-email-nixiaoming@huawei.com>
References: <1553954142-65515-1-git-send-email-nixiaoming@huawei.com>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero
To:     chao.xie@marvell.com, jbrunet@baylibre.com, mojha@codeaurora.org,
        mturquette@baylibre.com, nixiaoming@huawei.com,
        sboyd@codeaurora.org, soren.brinkmann@xilinx.com
Message-ID: <155606042712.15276.6873845293187802041@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Tue, 23 Apr 2019 16:00:27 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting nixiaoming (2019-03-30 06:55:42)
> The _get_div() function has a branch with a return value of 0
> Add a check on the return value of _get_div() to avoid divide-by-zero
>=20

Are you seeing this in practice? Or just trying to avoid a div-by-zero
case that you've found from inspection?=20

> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>