Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1b208e33c4f51630e2a336e95f25509fe7286e34.camel@russell.cc>
Subject: Re: [PATCH] powerpc/pseries: Use correct event modifier in
 rtas_parse_epow_errlog()
From:   Russell Currey <ruscur@russell.cc>
To:     Yue Haibing <yuehaibing@huawei.com>, paulus@samba.org,
        mpe@ellerman.id.au, mahesh@linux.vnet.ibm.com, npiggin@gmail.com,
        ganeshgr@linux.ibm.com, anton@samba.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Wed, 24 Apr 2019 11:29:47 +1000
In-Reply-To: <20190423143533.26952-1-yuehaibing@huawei.com>
References: <20190423143533.26952-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
> 
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
> interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Hello,

This fails to compile.

arch/powerpc/platforms/pseries/ras.c: In function
'rtas_parse_epow_errlog':
arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
undeclared (first use in this function); did you mean 'modifier'?
   handle_system_shutdown(event_modifier);
                          ^~~~~~~~~~~~~~
                          modifier

So yes, I assume you meant "modifier" instead of "event_modifier" as
mentioned in your commit message.  Did you compile this before sending?

(found by snowpatch)

- Russell