Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp173634yba; Tue, 23 Apr 2019 22:14:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhjEtsLL2HSQNgu0REBzktaP6DJp7trV9KZv/cR6SQCnilno76NgAbwtfP1yLXzNnTfAq/ X-Received: by 2002:a63:2a8f:: with SMTP id q137mr28900659pgq.31.1556082843137; Tue, 23 Apr 2019 22:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556082843; cv=none; d=google.com; s=arc-20160816; b=UZuFfL1Q6kkhiEOCZjsJeH/LEvKRFJ+Pd+YvrnKivIjN2ytvD5TZULdPLQ9JY1K2ah eTI5ucpjvwBUsBhjsUomogcQbtoY6y+K4PblCrrD6wPNylIPlGKxndvpMBr+darAe9iH 7bpIl8vYWTYo5oXNS4Szo+VLhJQo0JyZ0MszlaHtiB3Fo7gucZ3LwfcTNQxJhOpBv7l7 gsH3rGPn8/Y6Wv0H/HM+hxeGAGyG4wmTAjex7O1ZzZDEg4GBHr0WlV8cI1QCHFSrkuJe woKcbOGuiXZ51gVEZgFZ1OlNbWWaBJIUdkKSOhgbdTJkObyHKHlD8v4Tmjg9oe5jzTEZ E6Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fUalWZ/5nGVGsqGfpga60goqV8CAnV504OV8pw/jZfk=; b=Nf9zo06KtD4G8zEZj/+A1DFu1dNQCP/TWMihGZjIU9wW7ItweYNF1oaDUjKuUef+XE CmYJHsfHmXiahafFe6ZmEfFEjiQckY7iYc38l2q3k880dZX6OCB4MM89yJDgQqekv746 C89du7QIdwidKw6abz6l9KXHXtBmZqi+YdFUMBOnNeNwvgrRAptC94HsbZuFU4hg7VIq NZ7Ta08x3gbIyNhiO3yqX5VmEZbocNYmWf4OXwJVaS9VL7+2zvWSxppj6T2TMSWrYRtn E2GG8n4MYL443XWl/dpAuo0Wimge+A0pbJ76eTD7xMBU1gbbgUzcUh2fdq51oHaIj2Yl iuiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si17722642plo.368.2019.04.23.22.13.47; Tue, 23 Apr 2019 22:14:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbfDXFMz (ORCPT + 99 others); Wed, 24 Apr 2019 01:12:55 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:44915 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfDXFMy (ORCPT ); Wed, 24 Apr 2019 01:12:54 -0400 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hJADC-00026h-3q from Jiada_Wang@mentor.com ; Tue, 23 Apr 2019 22:12:50 -0700 Received: from jiwang-OptiPlex-980.tokyo.mentorg.com (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 23 Apr 2019 22:12:45 -0700 From: Jiada Wang To: , , CC: , , , , , , , , , , , , , , , Subject: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Date: Wed, 24 Apr 2019 14:11:43 +0900 Message-ID: <20190424051145.23072-1-jiada_wang@mentor.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ClientProxiedBy: SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are issues with interrupt handling in rcar_gen3_thermal driver. Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be triggered but not able to clear IRQ status, thus cause system to hang. Since the irq line isn't shared between different devices, so the proper interrupt type flag should be IRQF_ONESHOT. This patch-set fix these interrupt handling retated issues. --- v4: remove 'spinlock_t lock' add Fixes tag in ("thermal: rcar_gen3_thermal: fix interrupt type") fix typos in ("thermal: rcar_gen3_thermal: disable interrupt in .remove") v3: fix to use correct code base remove unused "flag" variable in rcar_gen3_thermal_irq v2: use irq type IRQF_ONESHOT instead of IRQF_SHARED disable interrupt in .remove v1: initial version Jiada Wang (2): thermal: rcar_gen3_thermal: fix interrupt type thermal: rcar_gen3_thermal: disable interrupt in .remove drivers/thermal/rcar_gen3_thermal.c | 41 +++++++---------------------- 1 file changed, 9 insertions(+), 32 deletions(-) -- 2.19.2