Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
To:     Leonard Crestez <leonard.crestez@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Abel Vesa <abel.vesa@nxp.com>
References: <20190424075946.23124-1-yuehaibing@huawei.com>
 <AM0PR04MB6434F319FA56FE9A1AC0572FEE3C0@AM0PR04MB6434.eurprd04.prod.outlook.com>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <2f2b461f-2ad3-c81e-0826-ed7819de5518@huawei.com>
Date:   Wed, 24 Apr 2019 16:47:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <AM0PR04MB6434F319FA56FE9A1AC0572FEE3C0@AM0PR04MB6434.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/4/24 16:11, Leonard Crestez wrote:
> On 4/24/2019 11:00 AM, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> During randconfig builds, I occasionally run into an invalid configuration
>>
>> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
>> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>>
>> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
>> selects SOC_BUS to fix it.
>>
>> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
>> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS
>>   	depends on ARCH_MXC || (COMPILE_TEST && OF)
>>   	depends on PM
>>   	select PM_GENERIC_DOMAINS
>> +	select SOC_BUS
>>   	default y if SOC_IMX7D
> 
> You should "select SOC_BUS" from "config ARCH_MXC" in arm64 
> Kconfig.platforms, not from a power domain implementation.
> 
> Your patch works because arm64 ARCH_MXC currently does "select 
> IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.

Yes, you are right, thanks!

> 
> --
> Regards,
> Leonard
> 
>