Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp341679yba; Wed, 24 Apr 2019 02:05:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqyN1/1wZ7P4F8Yn7B/i2/z1ldjJwu+uzjks65KN+VRoK1NzfKiSFP+MUNbghbza8dqgwQvy X-Received: by 2002:a17:902:6b03:: with SMTP id o3mr30565111plk.226.1556096729932; Wed, 24 Apr 2019 02:05:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556096729; cv=none; d=google.com; s=arc-20160816; b=ia6sEaav+nZTB/ZU4r8SGVQjC4e4+vf4pnt7v8aTykvLmzXM4iGjtW3tx7gSw/jL0t 3+s1BiwYawMEKXYuCdXdJNQI1mXAdhbmj2FMazE2dh2ZEYr5hbdwT6wiKB3ij/Fp2oud NTxRB+/+TQryvDaKi8IWo1F2a5tBmWu2Xma7HOUaWa2bKUwxfVgEu3sBlgFW464yVqqT kJacOM5y0vy840MxZ49DVyn2NqX+CJcvy9hs0rlz71tt+w0pmS3JlAWp4bxI8tSd61B6 BDWO4IAzjgGWwKEVJKpUaUNXV5KGQMrQdUVRwMGcq7O/PKMNRa9DZa629Hr2Y6VBLDT+ /B3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4B4mZi39i0XWuKLroY575XCcdNvvxzPvfQrYSmIyGH4=; b=eSnJlbA/jiFLIjE8oA+pe8f18jHpuEMbOcoNCMXSySf2wNQF4P7KUA1y68LBQa5FZh Vh434UQgeF9kBibcNwJAU+P3dEjp1kCEIE+Z8j8de8WH+dxxk5bKG2UbDcr+nixkw7uS EwcwV7YQDVsmyGl0D6+s+K4LvVOpGTs2/k7S9JXsKTqklh79/y5EvTCA9l0HZbuZaFb8 imx2R3S22UCgPlEaCDs1pCYmSGy2PMHc4pRdmSX3957mU66hpnwwN5OoqvorOyR7nigj /fkVTKOBhgccqkHVJA/nX/uao/imxZcg334sQ1WfvS6XCAe/JnF6zKGaxzHcugfQMmjC +anQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q86si18796662pfi.197.2019.04.24.02.05.14; Wed, 24 Apr 2019 02:05:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727537AbfDXJEG (ORCPT + 99 others); Wed, 24 Apr 2019 05:04:06 -0400 Received: from outbound-smtp05.blacknight.com ([81.17.249.38]:40794 "EHLO outbound-smtp05.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfDXJEG (ORCPT ); Wed, 24 Apr 2019 05:04:06 -0400 Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp05.blacknight.com (Postfix) with ESMTPS id 99DD498BFE for ; Wed, 24 Apr 2019 09:04:04 +0000 (UTC) Received: (qmail 31721 invoked from network); 24 Apr 2019 09:04:04 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[37.228.225.79]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 24 Apr 2019 09:04:04 -0000 Date: Wed, 24 Apr 2019 10:04:03 +0100 From: Mel Gorman To: Andrew Morton Cc: Andrey Ryabinin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/page_alloc: fix never set ALLOC_NOFRAGMENT flag Message-ID: <20190424090403.GS18914@techsingularity.net> References: <20190423120806.3503-1-aryabinin@virtuozzo.com> <20190423120806.3503-2-aryabinin@virtuozzo.com> <20190423120143.f555f77df02a266ba2a7f1fc@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20190423120143.f555f77df02a266ba2a7f1fc@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 23, 2019 at 12:01:43PM -0700, Andrew Morton wrote: > On Tue, 23 Apr 2019 15:08:06 +0300 Andrey Ryabinin wrote: > > > Commit 0a79cdad5eb2 ("mm: use alloc_flags to record if kswapd can wake") > > removed setting of the ALLOC_NOFRAGMENT flag. Bring it back. > > What are the runtime effects of this fix? The runtime effect is that ALLOC_NOFRAGMENT behaviour is restored so that allocations are spread across local zones to avoid fragmentation due to mixing pageblocks as long as possible. -- Mel Gorman SUSE Labs