Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190311224752.8337-1-valentin.schneider@arm.com> <20190311224752.8337-8-valentin.schneider@arm.com>
In-Reply-To: <20190311224752.8337-8-valentin.schneider@arm.com>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Wed, 24 Apr 2019 15:18:44 +0800
Message-ID: <CAEbi=3fPnEsF6hUK-p7de=+hyJ5UTF+uhb65QzNgmvNoh2TVPA@mail.gmail.com>
Subject: Re: [PATCH 07/14] nds32: ex-exit: Remove unneeded need_resched() loop
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Vincent Chen <deanbo422@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Valentin,

Valentin Schneider <valentin.schneider@arm.com> =E6=96=BC 2019=E5=B9=B43=E6=
=9C=8812=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=886:48=E5=AF=AB=E9=81=
=93=EF=BC=9A
>
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> ---
>  arch/nds32/kernel/ex-exit.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nds32/kernel/ex-exit.S b/arch/nds32/kernel/ex-exit.S
> index 97ba15cd4180..1df02a793364 100644
> --- a/arch/nds32/kernel/ex-exit.S
> +++ b/arch/nds32/kernel/ex-exit.S
> @@ -163,7 +163,7 @@ resume_kernel:
>         gie_disable
>         lwi     $t0, [tsk+#TSK_TI_PREEMPT]
>         bnez    $t0, no_work_pending
> -need_resched:
> +
>         lwi     $t0, [tsk+#TSK_TI_FLAGS]
>         andi    $p1, $t0, #_TIF_NEED_RESCHED
>         beqz    $p1, no_work_pending
> @@ -173,7 +173,7 @@ need_resched:
>         beqz    $t0, no_work_pending
>
>         jal     preempt_schedule_irq
> -       b       need_resched
> +       b       no_work_pending
>  #endif
>
>  /*

Thank you. :)
Acked-by: Greentime Hu <greentime@andestech.com>