Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp403811yba; Wed, 24 Apr 2019 03:22:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1Wp7aq+EuwhyRMvO6JK8hgeRHPp8OM4jxbX4BTEGhFK5ojLHAUBAR1ldJtI+J5svdZ0E7 X-Received: by 2002:aa7:8b83:: with SMTP id r3mr1537853pfd.248.1556101335822; Wed, 24 Apr 2019 03:22:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556101335; cv=none; d=google.com; s=arc-20160816; b=Iv5KJk3kGWzvC04cOqiP1y48HvsKVoLm0Cjb8DNGV0XH8AoUKOchZKgtvDtm36ISn1 su2eXy6b+hc7A866031Yiko2cX3tsZwaanyBFc0wMaSabWYxl42UxCpA9Y5vWKEf85Km OcHPDLo/d+wHOsNviXJJxnOXQIi0Rww5F8vAmCrDd175sqi0WeHbfImTmqECbEV0O/jD pVq6nVTreebPGzXUbL4vUuDoNqERqG5ias6x8EgGddUTJhF8Mwt0Mr0L1xxkCsztL+h4 ARonGSmGLINOlwt4oDMcmUiHDM5bEIJjypgyOVf+Byh4QB3Mcrn/qXohX7wC4YgesbVv k1uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=YUB6Zr4mQO1vo7mjsN1l9v+q+hPoYBype2WkI1xrxao=; b=zpw5oY85imwv7izgHIMY2NzP7gZBYXxtqxwivMj7eOyCmP/qMQzP2HwLJcYg9cxwta o7rx1lMucAsH2tfIx3+XkcNTOqTzPGs3Ybx09pDZfOVCdJzvdPTDkFA4jcYSN7EoEzJp dPVYO2/I2NrIjvm9JtpZRKv2C2DgFfo83dNfxY3THHo5IK2J8O+G2BY44Gs9owJkhTvY 0e5/alU8s9NuIrcf0xJ8uMRyRPSpalmJjEFO5ebEdAr9kWXTx9oAxpaqKVy+xHtOVq8r fTjbtD9m4LohF6EeOlYaDyzhckSli28Rxd1fkhGaNOZJFLdiL7W+nA9szpWyDsCsvDHc sjAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=luX2JALB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g30si2672265pgl.9.2019.04.24.03.22.00; Wed, 24 Apr 2019 03:22:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=luX2JALB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727367AbfDXJWA (ORCPT + 99 others); Wed, 24 Apr 2019 05:22:00 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:41248 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726451AbfDXJWA (ORCPT ); Wed, 24 Apr 2019 05:22:00 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3O9HQaJ030753; Wed, 24 Apr 2019 11:21:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=STMicroelectronics; bh=YUB6Zr4mQO1vo7mjsN1l9v+q+hPoYBype2WkI1xrxao=; b=luX2JALB3WHOeeP5YCpHnvsVvg4WlmXv1n8RpabTse8TQHjNSX5hV72EZ4eMKOyGQfGt BUyA8J6xq2++b/AdW54fFoM/ZL49MEALoyaTlXbxF1vZJj6SSw42GgM0Kib8Xl00v/X4 jOYsSiGb3yg4OL9KKiwARQKz1Lr8eMTDBs+erxIsyWyChqEbMxmqTkO3LmnhbvqT+sVr hhRw0/an189QX7EFvZ7Kp0DyWZ1CtD5rHtpyXnELojyO6zoq8GOBo1O72mVniuTgtqPP oM1sjH/q/V9Z3q9dHLyDZTH+THJPlnUjwlnYGjEuOqjoBgrSaFyLZ/x6tofRXp/i43yi vg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rytad5hba-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 11:21:45 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AA73234; Wed, 24 Apr 2019 09:21:44 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 839981559; Wed, 24 Apr 2019 09:21:44 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by SAFEX1HUBCAS21.st.com (10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 24 Apr 2019 11:21:44 +0200 Received: from localhost (10.201.23.25) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Apr 2019 11:21:43 +0200 From: Fabien Dessenne To: Vinod Koul , Dan Williams , Maxime Coquelin , Alexandre Torgue , Pierre-Yves MORDRET , , , , CC: Fabien Dessenne Subject: [PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get_irq() Date: Wed, 24 Apr 2019 11:21:25 +0200 Message-ID: <1556097685-7236-1-git-send-email-fabien.dessenne@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.25] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-24_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for requesting IRQ's resources, as they can be not ready yet. Using platform_get_irq() instead is preferred for getting IRQ even if it was not retrieved earlier. Signed-off-by: Fabien Dessenne --- drivers/dma/stm32-dma.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c index ba239b5..3306818 100644 --- a/drivers/dma/stm32-dma.c +++ b/drivers/dma/stm32-dma.c @@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev) for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) { chan = &dmadev->chan[i]; - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - ret = -EINVAL; - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); + chan->irq = platform_get_irq(pdev, i); + if (chan->irq < 0) { + ret = chan->irq; + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "No irq resource for chan %d\n", i); goto err_unregister; } - chan->irq = res->start; ret = devm_request_irq(&pdev->dev, chan->irq, stm32_dma_chan_irq, 0, dev_name(chan2dev(chan)), chan); -- 2.7.4