Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Yue Haibing <yuehaibing@huawei.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Abel Vesa <abel.vesa@nxp.com>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
Thread-Topic: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
Thread-Index: AQHU+nPLGm9MWjwEc0eIwVyKi03AFA==
Date:   Wed, 24 Apr 2019 08:11:42 +0000
Message-ID: <AM0PR04MB6434F319FA56FE9A1AC0572FEE3C0@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <20190424075946.23124-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 846023b5-7d12-42d0-99df-08d6c88c7c94
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2019 08:11:42.9233
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5505
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/24/2019 11:00 AM, Yue Haibing wrote:=0A=
> From: YueHaibing <yuehaibing@huawei.com>=0A=
> =0A=
> During randconfig builds, I occasionally run into an invalid configuratio=
n=0A=
> =0A=
> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':=0A=
> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_registe=
r'=0A=
> =0A=
> while CONFIG_SOC_BUS is not set, the building failed like this. This patc=
h=0A=
> selects SOC_BUS to fix it.=0A=
> =0A=
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig=0A=
> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS=0A=
>   	depends on ARCH_MXC || (COMPILE_TEST && OF)=0A=
>   	depends on PM=0A=
>   	select PM_GENERIC_DOMAINS=0A=
> +	select SOC_BUS=0A=
>   	default y if SOC_IMX7D=0A=
=0A=
You should "select SOC_BUS" from "config ARCH_MXC" in arm64 =0A=
Kconfig.platforms, not from a power domain implementation.=0A=
=0A=
Your patch works because arm64 ARCH_MXC currently does "select =0A=
IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=