Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553874548-31366-1-git-send-email-yannick.fertre@st.com> <ef8aa4e8-ebf9-ea01-d8db-fbf7740bc765@st.com>
In-Reply-To: <ef8aa4e8-ebf9-ea01-d8db-fbf7740bc765@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 24 Apr 2019 14:26:03 +0200
Message-ID: <CA+M3ks6RZmXjCh_r5MBLGeNb4vY4g8nOCX=cSbCe8GW4rHc4gQ@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le lun. 1 avr. 2019 =C3=A0 11:20, Philippe CORNU <philippe.cornu@st.com> a =
=C3=A9crit :
>
> Dear Yannick,
> Fully agree with this approach,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> On 3/29/19 4:49 PM, Yannick Fertr=C3=A9 wrote:
> > From: Philippe Cornu <philippe.cornu@st.com>
> >
> > Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> > inform the user in case of fifo underruns or
> > transfer errors.
> >
> > Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..15d8a02 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_p=
lane *plane,
> >
> >       mutex_lock(&ldev->err_lock);
> >       if (ldev->error_status & ISR_FUIF) {
> > -             DRM_DEBUG_DRIVER("Fifo underrun\n");
> > +             DRM_WARN("ltdc fifo underrun: please verify display mode\=
n");
> >               ldev->error_status &=3D ~ISR_FUIF;
> >       }
> >       if (ldev->error_status & ISR_TERRIF) {
> > -             DRM_DEBUG_DRIVER("Transfer error\n");
> > +             DRM_WARN("ltdc transfer error\n");
> >               ldev->error_status &=3D ~ISR_TERRIF;
> >       }
> >       mutex_unlock(&ldev->err_lock);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel