Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1554283216-2700-1-git-send-email-yannick.fertre@st.com> <51100130-dfe9-ae21-6efb-b1394f607bdd@st.com>
In-Reply-To: <51100130-dfe9-ae21-6efb-b1394f607bdd@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 24 Apr 2019 14:28:25 +0200
Message-ID: <CA+M3ks4h1uMY=jFQDJZceWi7udhiKQPLLr-3KqbDDjf17hmzSw@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: limit number of layer to avoid memory overflow
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le ven. 5 avr. 2019 =C3=A0 18:30, Philippe CORNU <philippe.cornu@st.com> a =
=C3=A9crit :
>
> Dear Yannick,
> Thank you for your patch,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :)
>
> On 4/3/19 11:20 AM, Yannick Fertr=C3=A9 wrote:
> > If the number of layer is greater than LTDC_MAX_LAYER, we can have
> > memory overflow when reading plane_fpsi[].
> >
> > Signed-off-by: Yannick Fertr=C3=A9 <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index 32fd6a3..05bd4b6 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -1021,10 +1021,13 @@ static int ltdc_get_caps(struct drm_device *dde=
v)
> >       struct ltdc_device *ldev =3D ddev->dev_private;
> >       u32 bus_width_log2, lcr, gc2r;
> >
> > -     /* at least 1 layer must be managed */
> > +     /*
> > +      * at least 1 layer must be managed & the number of layers
> > +      * must not exceed LTDC_MAX_LAYER
> > +      */
> >       lcr =3D reg_read(ldev->regs, LTDC_LCR);
> >
> > -     ldev->caps.nb_layers =3D max_t(int, lcr, 1);
> > +     ldev->caps.nb_layers =3D clamp((int)lcr, 1, LTDC_MAX_LAYER);
> >
> >       /* set data bus width */
> >       gc2r =3D reg_read(ldev->regs, LTDC_GC2R);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel