Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1554283514-2960-1-git-send-email-yannick.fertre@st.com> <f031fc0f-ea81-1083-df7a-e7ce413d2868@st.com>
In-Reply-To: <f031fc0f-ea81-1083-df7a-e7ce413d2868@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 24 Apr 2019 14:29:55 +0200
Message-ID: <CA+M3ks4q6J1pxd2ooSU+pDssX9u_sWCMeqtT3a4YqALhtAuimA@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: add modifier support
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le ven. 5 avr. 2019 =C3=A0 18:32, Philippe CORNU <philippe.cornu@st.com> a =
=C3=A9crit :
>
>
>
> On 4/3/19 11:25 AM, Yannick Fertr=C3=A9 wrote:
> > Signed-off-by: Mickael Reulier <mickael.reulier@st.com>
> > Signed-off-by: Yannick Fertr=C3=A9 <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 21 ++++++++++++++++++++-
> >   1 file changed, 20 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..6fa8fbc 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -232,6 +232,11 @@ static const enum ltdc_pix_fmt ltdc_pix_fmt_a1[NB_=
PF] =3D {
> >       PF_ARGB4444             /* 0x07 */
> >   };
> >
> > +static const u64 ltdc_format_modifiers[] =3D {
> > +     DRM_FORMAT_MOD_LINEAR,
> > +     DRM_FORMAT_MOD_INVALID
> > +};
> > +
> >   static inline u32 reg_read(void __iomem *base, u32 reg)
> >   {
> >       return readl_relaxed(base + reg);
> > @@ -864,6 +869,16 @@ static void ltdc_plane_atomic_print_state(struct d=
rm_printer *p,
> >       fpsi->counter =3D 0;
> >   }
> >
> > +static bool ltdc_plane_format_mod_supported(struct drm_plane *plane,
> > +                                         u32 format,
> > +                                         u64 modifier)
> > +{
> > +     if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR)
> > +             return true;
> > +
> > +     return false;
> > +}
> > +
> >   static const struct drm_plane_funcs ltdc_plane_funcs =3D {
> >       .update_plane =3D drm_atomic_helper_update_plane,
> >       .disable_plane =3D drm_atomic_helper_disable_plane,
> > @@ -872,6 +887,7 @@ static const struct drm_plane_funcs ltdc_plane_func=
s =3D {
> >       .atomic_duplicate_state =3D drm_atomic_helper_plane_duplicate_sta=
te,
> >       .atomic_destroy_state =3D drm_atomic_helper_plane_destroy_state,
> >       .atomic_print_state =3D ltdc_plane_atomic_print_state,
> > +     .format_mod_supported =3D ltdc_plane_format_mod_supported,
> >   };
> >
> >   static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =
=3D {
> > @@ -890,6 +906,7 @@ static struct drm_plane *ltdc_plane_create(struct d=
rm_device *ddev,
> >       unsigned int i, nb_fmt =3D 0;
> >       u32 formats[NB_PF * 2];
> >       u32 drm_fmt, drm_fmt_no_alpha;
> > +     const u64 *modifiers =3D ltdc_format_modifiers;
> >       int ret;
> >
> >       /* Get supported pixel formats */
> > @@ -918,7 +935,7 @@ static struct drm_plane *ltdc_plane_create(struct d=
rm_device *ddev,
> >
> >       ret =3D drm_universal_plane_init(ddev, plane, possible_crtcs,
> >                                      &ltdc_plane_funcs, formats, nb_fmt=
,
> > -                                    NULL, type, NULL);
> > +                                    modifiers, type, NULL);
> >       if (ret < 0)
> >               return NULL;
> >
> > @@ -1179,6 +1196,8 @@ int ltdc_load(struct drm_device *ddev)
> >               goto err;
> >       }
> >
> > +     ddev->mode_config.allow_fb_modifiers =3D true;
> > +
>
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>

Applied on drm-misc-next even if I got issue with the author name encoding

Thanks,
Benjamin

> Philippe :)
>
> >       ret =3D ltdc_crtc_init(ddev, crtc);
> >       if (ret) {
> >               DRM_ERROR("Failed to init crtc\n");
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel