Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during
 probe
To:     Fabien Dessenne <fabien.dessenne@st.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        <linux-iio@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <1556110286-1526-1-git-send-email-fabien.dessenne@st.com>
 <1556110286-1526-3-git-send-email-fabien.dessenne@st.com>
From:   Fabrice Gasnier <fabrice.gasnier@st.com>
Message-ID: <b46f9525-53c0-d874-c88f-c6e351736b04@st.com>
Date:   Wed, 24 Apr 2019 14:55:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1556110286-1526-3-git-send-email-fabien.dessenne@st.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the devm_ioremap_resource() error value.
> Also return the devm_clk_get() error value instead of -EINVAL.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---


Hi Fabien,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks,
Fabrice

>  drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 0a4d374..26e2011 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
>  	}
>  	priv->dfsdm.phys_base = res->start;
>  	priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(priv->dfsdm.base))
> +		return PTR_ERR(priv->dfsdm.base);
>  
>  	/*
>  	 * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
>  	 */
>  	priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
>  	if (IS_ERR(priv->clk)) {
> -		dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> -		return -EINVAL;
> +		ret = PTR_ERR(priv->clk);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> +		return ret;
>  	}
>  
>  	priv->aclk = devm_clk_get(&pdev->dev, "audio");
>