Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk>
 <155373036414.7602.7964458548629410897.stgit@warthog.procyon.org.uk>
In-Reply-To: <155373036414.7602.7964458548629410897.stgit@warthog.procyon.org.uk>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Wed, 24 Apr 2019 15:53:29 +0200
Message-ID: <CAJfpegvowwePJHEMRkaabx-NxLoJ5f8_QziPFyQUui+bmAaT1w@mail.gmail.com>
Subject: Re: [RFC PATCH 44/68] vfs: Convert fuse to use the new mount API
To:     David Howells <dhowells@redhat.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 28, 2019 at 12:46 AM David Howells <dhowells@redhat.com> wrote:
>
> Convert the fuse filesystem to the new internal mount API as the old
> one will be obsoleted and removed.  This allows greater flexibility in
> communication of mount parameters between userspace, the VFS and the
> filesystem.
>
> See Documentation/filesystems/mount_api.txt for more information.

Should I be applying this, together with the vfs dependencies?  Or
will you take care of these?

One minor comment is that fuse conventionally uses "struct fuse_conn
*fc", so "struct fs_context *fc" is confusing here.  There's one place
you use "struct fs_context *fsc", which seems the right thing to do
for all the cases.

Thanks,
Miklos