Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Matt Redfearn <matt.redfearn@thinci.com>
To:     Andrzej Hajda <a.hajda@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Philippe Cornu <philippe.cornu@st.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Matthew Redfearn <matthew.redfearn@thinci.com>,
        Nickey Yang <nickey.yang@rock-chips.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Archit Taneja <architt@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable
Thread-Topic: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call
 post_disable
Thread-Index: AQHU+qkUj1HzsBP9eU2naClnjE4Oug==
Date:   Wed, 24 Apr 2019 14:22:00 +0000
Message-ID: <20190424142148.25927-1-matt.redfearn@thinci.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-originating-ip: [87.242.198.86]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 01f325b7-b6c9-4a1d-02fc-08d6c8c036c2
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);SRVR:MA1PR01MB3194;
x-ms-traffictypediagnostic: MA1PR01MB3194:
x-microsoft-antispam-prvs: <MA1PR01MB3194ECBCCD9BE922ABDBD1DDF13C0@MA1PR01MB3194.INDPRD01.PROD.OUTLOOK.COM>
x-forefront-prvs: 00179089FD
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(39850400004)(396003)(376002)(366004)(346002)(189003)(199004)(8676002)(316002)(2906002)(2616005)(486006)(476003)(66066001)(36756003)(81166006)(14454004)(81156014)(478600001)(6506007)(256004)(14444005)(386003)(26005)(68736007)(186003)(66946007)(73956011)(5660300002)(64756008)(66476007)(3846002)(6116002)(66556008)(50226002)(7416002)(66446008)(8936002)(102836004)(6512007)(71190400001)(1076003)(71200400001)(52116002)(97736004)(53936002)(4326008)(6436002)(25786009)(7736002)(305945005)(99286004)(6486002)(110136005)(54906003);DIR:OUT;SFP:1102;SCL:1;SRVR:MA1PR01MB3194;H:MA1PR01MB3770.INDPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: thinci.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: sg3dx2+o+UUHuRtsoVFW/0iuwk0H6KyjAeElq9qO7ChA8wvTc7Xf8cTRsEdUetV6vZjotTgKFcwzx19RpEiPahSUX8uH25iKAh2hVS2kph+r/PeLZ1kL1mhLHKrcF3onJBrVTmB/4KdPEcW6aD2GaINtofLObs3m8ckbkQbnYI+2hQFC0EazW7WOtZST+VjANvUN3SRhTTnL0HJTG6KYxhvuDC5+5V9uv4gOwTIQXi3GEx6N1LzXBHs8nrVztd3Xjso9vlEx+pRkU+bRHbDWuaOG5WYzjvT1GXY/t/KNLvx+1M8ulbUiR+yxqi+MKH7AR2Q5UOV1JurnUup32Zg+o8sJklIdl6a2Nm5HQWZm9Zn92eD5PHkRl6AOtAnb5T3m9mJwNXaIftWnrmGWe8WwCRaJyZr+8GCC1aeDDZVbE/I=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: thinci.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01f325b7-b6c9-4a1d-02fc-08d6c8c036c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2019 14:22:00.0666
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9d1c3c89-8615-4064-88a7-bb1a8537c779
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA1PR01MB3194
X-TMASE-Version: StarCloud-1.3-8.2.1013-24572.000
X-TMASE-Result: 10--2.280300-4.000000
X-TMASE-MatchedRID: 3DCWtTm2Z9+T4QuBHRkf9pN3sInxtjDTZn7KXuDApb5+YesuCgkiXHbk
        pdDhAgYmo2jEjZ+uot3kAOn8zTy8vHrSP9RtGZYoQ4srjeRbxTZCX8V1FiRRkt9RlPzeVuQQ+1B
        ysa1PtqSdE6czz+eVhdeS5VWUkyw98Nk4qYUuW8jghWDeMRWA/X0tCKdnhB58kS/ZvrGh80FzqE
        fyvgNYMCKDrFoK/LNdjoczmuoPCq3BUnDL4C6uf8M978+ZKU/PGHHSjzp4a9o5MSHZbTN+ihPUS
        PPaUOyAZE94MvHK5c/oWOGxHQO6LibrOVhfmLpYXnWDJ6BvyeaN1XIGgb30UjMO7WwucqsLGtMi
        kpjqoh07bMumEHVdMRfqtr5XQz6G
X-TM-Deliver-Signature: 3DEC359A54C2D4F0FB6BC97639A56A68
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The DRM documentation states that post_disable is an optional callback.
As such an implementing device may not populate it. To avoid panicing
the kernel by calling a NULL function pointer, we should NULL check it
before blindy calling it.

Signed-off-by: Matt Redfearn <matt.redfearn@thinci.com>

---

 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/dr=
m/bridge/synopsys/dw-mipi-dsi.c
index 38e88071363..0ee440216b8 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -805,7 +805,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_=
bridge *bridge)
 	 * This needs to be fixed in the drm_bridge framework and the API
 	 * needs to be updated to manage our own call chains...
 	 */
-	dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
+	if (dsi->panel_bridge->funcs->post_disable)
+		dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
=20
 	if (dsi->slave) {
 		dw_mipi_dsi_disable(dsi->slave);
--=20
2.17.1