Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp651653yba; Wed, 24 Apr 2019 07:29:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbLRlL7psBr1ctxU+Ld86ZWc7nqzo6AkPul7yNifknBm6hw2VVqmDwPRMHC8EUMIyEZ61S X-Received: by 2002:a17:902:31c3:: with SMTP id x61mr32467385plb.143.1556116149178; Wed, 24 Apr 2019 07:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556116149; cv=none; d=google.com; s=arc-20160816; b=cRizfo/Z4jEDR/ovEDEcYefFBxk1Iy1j6dMFBy5UdhlR3lbyl+p/+bfNp48yEvZqpB XhTL2dKccSZTU/EF2Sqp2pAaqM0QbVFQo92p9OQ6zF1+Y8V3GkoCmnwFVdhLUX7Ye0ON zgCYp7dpzFj4wqaXOIjLuDXL9SEX1vAJ/MfQ+Xe9cn3/xnOfzq+UKYriSKvbyjaMy6hK LVK0hZ89y4IkZiNOHChcB1lFmmf5k3x0icazQoxdS62kOxPcsKpFktx8mmmCFqBIpi/z b2ELapWdJM7hqCC3rETUsEkPOVcQPzjyv26XK+FlBuzaziVeFWhDNL9s4wm8NT1sB2l5 Rnmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7oP5fT8kwItGkJYmh1HwDmxIPTSBkNNmQFuQY9MvsiE=; b=jqVEivFbUTTuJ0WDQoEbDv7AKCxymVtelPvFN9IhLCgXR83PSDHVdv10SBSjjzKF+L l9KGwoohFhC2b2DiwH9ZS+5eWiG7YXX3JZLr4KKfb5EU69IeXWKhgurZ5oVw9HTVFIge KVQb4qei/Sfy6vnbl+XSSw/IVoet2iQT8lMmwbdhMz48z11T+St0yJAzGZbaZnZhzVzC uIxZMfGEc8LU9wVITJwi1X119S5Rl5CL/jfki9Rnv6osta2QbKvYllNJLYw1n72T+N6c Zk4bQE+i38BVKiTKnfUOeIHdizzgKHU1qa0uQ9RtKA17w7VGEoviLuxAy/ZjHIHp3Lrp ojbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=K5sWZ2dA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m134si18045553pga.588.2019.04.24.07.28.53; Wed, 24 Apr 2019 07:29:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=K5sWZ2dA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730491AbfDXO1z (ORCPT + 99 others); Wed, 24 Apr 2019 10:27:55 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:52039 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbfDXO1z (ORCPT ); Wed, 24 Apr 2019 10:27:55 -0400 Received: by mail-it1-f194.google.com with SMTP id s3so6674857itk.1 for ; Wed, 24 Apr 2019 07:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7oP5fT8kwItGkJYmh1HwDmxIPTSBkNNmQFuQY9MvsiE=; b=K5sWZ2dAMrxBProSStQH6dmf1gQ0JZFcMF8rxHGftJU9Z08CMj/7iOejnjNkef/5Vx rWSYPv2U30R4jVjcVH0IQ4CvhS/zWSeOOauy6R3OirrHvPzYEgK/KWBDuuHJlQOOdurJ T+jR1Zh9JMG72H4okNxfdGnJAxQwdEB1M9oa4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7oP5fT8kwItGkJYmh1HwDmxIPTSBkNNmQFuQY9MvsiE=; b=EnX0reUfqW4+4jDi+ySjqXthBRGSB1GRwVNh9vyj7laYY+B5Eaz0EUJFRWKbjtPbO1 T6UeFi7OG4Tao/Z8HOj0t1P+2lA10pebTE6+33x6TqXB7peSmK3YcHRzro2P+oX+hY/O C0ubFHzVc6o3oCkjTQH9jmT37Lv5d2mibeyFQaeESmQZk+mRxaC11fcwewzKVN6P9qh3 j/MJrxHrgtzfpORbUCh1PBmFNF4iv/eQf3C1rpNeNrerk8h7OWfYjI4S+Oa+SAEYqpFH VUJVrcMAEGKEit4lkDJ/bm+A3TJhic+mED1x/C3JISpG9sagaP/oPI+G5pDgbzS8FAoj xnlA== X-Gm-Message-State: APjAAAXxz3rD+vdeRByiXy1+1KcaKTPWRDND+WOKsbaNEQQmRAXuiQ6P 2mAVnOiCqFDXdsrq2ZKEXgbOo67zlJiG6c7/xh0flw== X-Received: by 2002:a24:1312:: with SMTP id 18mr6171433itz.121.1556116074814; Wed, 24 Apr 2019 07:27:54 -0700 (PDT) MIME-Version: 1.0 References: <20190424141411.24418-1-abbotti@mev.co.uk> In-Reply-To: <20190424141411.24418-1-abbotti@mev.co.uk> From: Miklos Szeredi Date: Wed, 24 Apr 2019 16:27:43 +0200 Message-ID: Subject: Re: [PATCH] fuse: Add ioctl flag for x32 compat ioctl To: Ian Abbott Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 4:14 PM Ian Abbott wrote: > > Currently, a CUSE server running on a 64-bit kernel can tell when an > ioctl request comes from a process running a 32-bit ABI, but cannot tell > whether the requesting process is using legacy IA32 emulation or x32 > ABI. In particular, the server does not know the size of the client > process's `time_t` type. > > For 64-bit kernels, the `FUSE_IOCTL_COMPAT` and `FUSE_IOCTL_32BIT` flags > are currently set in the ioctl input request (`struct fuse_ioctl_in` > member `flags`) for a 32-bit requesting process. This patch defines a > new flag `FUSE_IOCTL_COMPAT_X32` and sets it if the 32-bit requesting > process is using the x32 ABI. This allows the server process to > distinguish between requests from requesting client processes using IA32 > emulation or the x32 ABI and so infer the size of the client process's > `time_t` type and any other IA32/x32 differences. Thanks, applied. Miklos