Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp707749yba; Wed, 24 Apr 2019 08:20:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/KLY1b6ZTVeTwAVquuV8wnL/osN8bYdZaTHStHB4eMJTGMZQ64caiUR8k/qe2ObkzkI2H X-Received: by 2002:a63:161d:: with SMTP id w29mr8226229pgl.395.1556119229421; Wed, 24 Apr 2019 08:20:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556119229; cv=none; d=google.com; s=arc-20160816; b=UsarFcKYqdW2QtPNzmn8x6PX3u1Kbmm8FTZKm+JWMOQ10xptSrC7Glu5hTe4kv+s76 cnW658rg8nTmyvaYJiIeKy8IdEu7gStVzfI/mgjjNT7u33FkY8Mole9cu6ailK6jtEBe gx6qXSCC0WvdvSzOWHfeW+2Bv+JtY5xjxhQqo0ZItzJMjk1pe/Ue0LxZNuBYAAeN0QBk kFPvMPOpTV0WR9PKOY7ZaEBULnIIivJoAsyEPdz7DPdF0tZbLzX6PQSwR7oNUvCSOaoV /d5Ea091zecYGCMMVD6D83osfFQ89c43X3c+B0w+Ufy1GmJxGiEqgsb5TdVMGJCnzEWV LQ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=KmHj9BJNTsMjihCbz69dy7mwpmwsOJzd/iH+JvmR26E=; b=Yqfsatprt9m5fLA33osJ8FiApx89JG5uusO1/lPbjKZRlhnHD6zhu32RIcxxdlsij7 HVCrIr/s6DfUr7MmaEY8xo/FLkSho3sC8w8mLCXxj+zi4ZNf9Q0tn7HprEKrX9bkDAaI L/xOIM6mLmp1wMLhVe4z2ziGWh95P2c9smvT8HxaQIZca2RooHJXjK3TlEQ2cJoioqAb xAnjd8sM42I2oQ2Lu8/MZJZmnbRjMPtCoFM8kcITeI/ndyB4VXkO+SFq+ns5IP/WkPpK 2FPgz5V2p2OJqAMVYLYuXJk6zLvux0KEJmyuEPJzVHAY3bLdQIS+I8BgUUsT9Gi7W0c4 wubg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=eHQCBwjp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si15850780pgf.105.2019.04.24.08.20.12; Wed, 24 Apr 2019 08:20:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=eHQCBwjp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730578AbfDXPTQ (ORCPT + 99 others); Wed, 24 Apr 2019 11:19:16 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:41758 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfDXPTQ (ORCPT ); Wed, 24 Apr 2019 11:19:16 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OFG4bg017755; Wed, 24 Apr 2019 17:19:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=STMicroelectronics; bh=KmHj9BJNTsMjihCbz69dy7mwpmwsOJzd/iH+JvmR26E=; b=eHQCBwjpnyB+zKEZzHlzscC6ukPdjAR3OEoorh10R5dSFdvoNT8Gk+6t6iul559F6eli gpBxmT60bezD+vBAqc6ZamQwvygil3zluOCwWnnvn6OJ8aCkv+cADI4sLUAzoPdFHQvN 4B3gqgUsyj91R2eLMuf14de+Bm0w5g7GOSCqVXzTqYMPkNwSukmEpaDl1SCIPa3v0fA7 i6GFzNuLgx8ixU6AlmNa5aQ1K0hI+Etqq/lwcL2ufsdYfk3yp8vGiFQaZWuyzksCulZN aRGr6D/2aT//8xSCAaKtWC6uFFvxBLjrYotomP2Duub/CMzFDSFooladjQRDyAEIwpcj dA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ryrvxea79-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 17:19:06 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2941831; Wed, 24 Apr 2019 15:19:06 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0A3F128FC; Wed, 24 Apr 2019 15:19:06 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by SAFEX1HUBCAS21.st.com (10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 24 Apr 2019 17:19:05 +0200 Received: from localhost (10.201.23.25) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Apr 2019 17:19:05 +0200 From: Fabien Dessenne To: Mark Brown , Maxime Coquelin , Alexandre Torgue , Ludovic Barre , Christophe KERELLO , , , , CC: Fabien Dessenne Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case Date: Wed, 24 Apr 2019 17:19:00 +0200 Message-ID: <1556119140-3319-1-git-send-email-fabien.dessenne@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.25] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-24_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne --- drivers/spi/spi-stm32-qspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa..42f8e3c 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "IRQ error missing or invalid\n"); + return irq; + } + ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0, dev_name(dev), qspi); if (ret) { -- 2.7.4