Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp710969yba; Wed, 24 Apr 2019 08:23:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqymqgTgW6o6s8KkIVbfj0TLdfnv9GoG3aCq8UOOo8wscDvdFahUWorW0PpNVFMWRTnYBsjD X-Received: by 2002:a17:902:7e05:: with SMTP id b5mr33985338plm.127.1556119413494; Wed, 24 Apr 2019 08:23:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556119413; cv=none; d=google.com; s=arc-20160816; b=CCUHrf2LmM/9h8VwKBQwZ0QshPFrbDyo7F5r283k7f5Vz85Kq7cN72Rf8TZg/8R9cZ 8SV8vBco+Ec6pbO/cO6vkPKY8RpdvgJDiJfIljZVhrA5NZcIchINF6xx4t0AqpeEOJCl 23tUEytyNFb5mU4qEwbHZdx8Wu6Lhvz4KfLKXU1oS7DEnEPX44TdkvoXUhXwaH+vq0lU L08sVxRPoeqUFe5/gfBV0HBAPhBzNWZoNXN35xbvQjSZitmtHAPk2NkeWNtY0xr5DFLX ngUellxHjyUqchbrQ00+wG7H4bMOHEWa9JH2snNrT8zhnUd9yP163p6AOSeq9u3cTbPw BeWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:from:content-id :mime-version:subject:cc:to:references:in-reply-to:organization; bh=L9LXiSDJpGNtEjj/vMVuiQrwTm4bST4wI6D7U1IyCVE=; b=NqzZ9Seuh5LWcp0zrInc7cwJvQ/acEBVcU0ZNeeSJkDjZM7r8x9fqSkInP5Hay/3oI +eogYsIUYdPYqDsyuvmp91N/0driQXWU37bYVludlhXCGr2W8Er0KtimS7mLbx8nJEF4 8O2XlBjUycvzHZJ/P/m6LrFGVbcX75Xno9Bb/lbo2roK7TzUf7BBnK5Ld0LBmh/SA0D1 tpCZ1xx4xJdBKBMMtLLz9os86mMg2f2/xKRcmQzCTPVvLbiQZ7hN11AHpopjr3BQMLC8 FzE0bmw57aCXHTFgbVgDp4KFJFFAEYvylQaRsmvgytU3enEkoh1oIMdnXxv+P7cbzbXF JgXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si18186841pgo.122.2019.04.24.08.23.17; Wed, 24 Apr 2019 08:23:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730578AbfDXPWF (ORCPT + 99 others); Wed, 24 Apr 2019 11:22:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbfDXPWF (ORCPT ); Wed, 24 Apr 2019 11:22:05 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BC5330B49ED; Wed, 24 Apr 2019 15:22:05 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CB3E5D704; Wed, 24 Apr 2019 15:22:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 In-Reply-To: References: <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk> <155373036414.7602.7964458548629410897.stgit@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 44/68] vfs: Convert fuse to use the new mount API MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3077.1556119203.1@warthog.procyon.org.uk> From: David Howells Date: Wed, 24 Apr 2019 16:22:03 +0100 Message-ID: <3217.1556119323@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 24 Apr 2019 15:22:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Should I be applying this, together with the vfs dependencies? Or > will you take care of these? I'm hoping Al will take the entire series. > One minor comment is that fuse conventionally uses "struct fuse_conn > *fc", so "struct fs_context *fc" is confusing here. There's one place > you use "struct fs_context *fsc", which seems the right thing to do > for all the cases. Except in ceph, where "struct ceph_fs_client *fsc" is a common thing... David