Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Apr 2019 11:17:32 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Raphael Gault <Raphael.Gault@arm.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>,
        Julien Thierry <Julien.Thierry@arm.com>
Subject: Re: [RFC 1/6] objtool: Refactor code to make it more suitable for
 multiple architecture support
Message-ID: <20190424161732.lnttohdvhujtey64@treble>
References: <20190409135243.12424-1-raphael.gault@arm.com>
 <20190409135243.12424-2-raphael.gault@arm.com>
 <20190423201306.wyb57hz7xrvqbn75@treble>
 <13212ab1-20fe-88c6-f121-acd8ea623757@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <13212ab1-20fe-88c6-f121-acd8ea623757@arm.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 24, 2019 at 04:11:57PM +0000, Raphael Gault wrote:
> On 4/23/19 9:13 PM, Josh Poimboeuf wrote:
> > arch_dest_rela_addend_offset() might be a more descriptive name.  Also
> > it might be simpler to just make it an arch-specific macro which is 0 on
> > arm64 and 4 on x86.
> >
> > "compute" is implied, it can probably be removed from the names to make
> > them a little more concise.
> >
> 
> I am more in favor of the functions, I have to admit I don't know which
> is really better but in any event I will rename them.

If you prefer functions, that's fine with me.  I don't have a strong
preference.

-- 
Josh