Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <AF4D908CC0E2A24EB308A26962C8C3BDEB1A2B@DGGEMI530-MBX.china.huawei.com>
 <20190424161641.GI16167@redhat.com>
In-Reply-To: <20190424161641.GI16167@redhat.com>
From:   Christian Brauner <christian@brauner.io>
Date:   Wed, 24 Apr 2019 18:19:25 +0200
Message-ID: <CAHrFyr6rR=TMepEpFK0hQRQ-qMF8m4izf+WxdzGXEO7S_TVnQg@mail.gmail.com>
Subject: Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     weizhenliang <weizhenliang@huawei.com>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>,
        "colona@arista.com" <colona@arista.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "deepa.kernel@gmail.com" <deepa.kernel@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 24, 2019 at 6:16 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 04/24, weizhenliang wrote:
> >
> > On 04/24, Oleg wrote:
> > >On 04/24, Christian Brauner wrote:
> > >>
> > >> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote:
> > >>
> > >> > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
> > >
> > >Yes, but ...
> > >
> > >> > Reported-by: kbuild test robot <lkp@intel.com>
> > >
> > >Hmm, really?
> >
> > Yes, the kbuild test robot says that if I fix the problem with the third parameter type,
> > I should add this tag. What is wrong or missing?
>
> But this patch does not fix the problem reported by robot, your patch
> (which introduced that problem) was dropped, the problem has gone.
>
> With this "Reported-by: kbuild test robot <lkp@intel.com>" tag it looks
> as if test-robot has found the problem you are trying to fix: the lack of
> trace_signal_deliver(SIGKILL).

Yeah, Oleg's absolutely right. That tag should just go.
The Fixes line is all that we want, I think.

Christian