Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp836909yba; Wed, 24 Apr 2019 10:23:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYcP13YO93RmejginU4/FB+BpqOl3ixe70yHKU/nF5pY7461wIWf82OsWcaLCq7sCRrqvD X-Received: by 2002:a63:945:: with SMTP id 66mr32012910pgj.128.1556126589852; Wed, 24 Apr 2019 10:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556126589; cv=none; d=google.com; s=arc-20160816; b=Jd6S3NCGyCjdhg/4U6+DLjycPjDwJ5/BNTs2NcgWBnpKc+166yj/ge+OObH1/eA65C v/R+aZaFH8NknNmXFDxL0LuJ+DCTdLkvWBBrQ2Y4nxFCwnll0yZwrryvdhyp2395fNVQ i3dpy5Pfo4s8J7vLn8tqB/ke0pwVruvf2EFH1pd/Ke5RowBxG2WUNcePWcP/s77+G4Xo D/x5pvLtpgv4bozuzkdZhTlGW5RysFp+uRbcmxJkYA5OvvWWpYw+vMAnekbjgr9HZBCy 9cOGkObHeXIeObxWfdn6UpQ00GmDbsS1f4EV6rWiUiWBW3rGbzJ+2Y37cQ+K41vbLIJZ ZT8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8LjnCRu41bLdfmZZyFiVggYAag6fj1fPoQb5aY8+RHM=; b=tF1tKquy4K4II0ox58w1iOyvfvoCFwDcXRbog95ZKvLlztRxpSIEfVSAKfZ8gP3THz xalEQbMNaF5XklDw8s47ARZUsgDJP2hZtocaP/MGZRHF+epFG6aVZMJCfb0OrzDqrzKZ aYlSZdXuiJfxUES1a7/22mPAbIBe+rPCOq6zT76jZb3SAqYrPGTvV5WeYEzkAuQfzign 6xa2CtATpyHLiP+sbHrWXyEsBbxMFGu/J6Z1qSD5FvIGX3KcX6aIwSr/PxfvfOZvee+D us+Ue1YtnLFHvkAw5gHg1kKljWGViUNEz3cBrSBnKDVS8O4v1utVsM42k22vN92oRRhC ONuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RchZNklW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si19288478pfi.214.2019.04.24.10.22.54; Wed, 24 Apr 2019 10:23:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RchZNklW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389316AbfDXRVU (ORCPT + 99 others); Wed, 24 Apr 2019 13:21:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:46788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389283AbfDXRVS (ORCPT ); Wed, 24 Apr 2019 13:21:18 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52C9B205ED; Wed, 24 Apr 2019 17:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126477; bh=1IbneeFxs0YGSLZoGnP9YUCxnrKT6HnZjpdkW+uChFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RchZNklWikEih03PeE3IAFr0YE7+3fTq18Mxx7Qclu8VJ0rik7TB2WlI/cUnZ3oTk nIyn4AlfFrXW1qlO8VhrO/5asIJa70oVL4FnZXY6QENimkHetFxthQnObjHIR0geDf nU4N01eJMZgQvZxN9GHW+qXQfwmfk4e1it3XMvJM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Simek , Sasha Levin Subject: [PATCH 4.4 123/168] serial: uartps: console_setup() cant be placed to init section Date: Wed, 24 Apr 2019 19:09:27 +0200 Message-Id: <20190424170930.661710689@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170923.452349382@linuxfoundation.org> References: <20190424170923.452349382@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ] When console device is rebinded, console_setup() is called again. But marking it as __init means that function will be clear after boot is complete. If console device is binded again console_setup() is not found and error "Unable to handle kernel paging request at virtual address" is reported. Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 4f2f4aca8d2e..06efcef1b495 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1145,7 +1145,7 @@ static void cdns_uart_console_write(struct console *co, const char *s, * * Return: 0 on success, negative errno otherwise. */ -static int __init cdns_uart_console_setup(struct console *co, char *options) +static int cdns_uart_console_setup(struct console *co, char *options) { struct uart_port *port = &cdns_uart_port[co->index]; int baud = 9600; -- 2.19.1