Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp849161yba; Wed, 24 Apr 2019 10:34:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMJaq5oa8G1jU/pMOhSaYBOozFlu/0weNJKdPUhhkoaqMYdKek2hV7yW2SuKPNKPnuEZVu X-Received: by 2002:a63:374b:: with SMTP id g11mr32227735pgn.421.1556127291566; Wed, 24 Apr 2019 10:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556127291; cv=none; d=google.com; s=arc-20160816; b=ScpO+v3L124XiU5u1Iy4MxKDPKJau1/qtZV74JfO6yAW6EAmsGIVU4b2kEXQmnkfFF XwTJFOq/mpr/v1hprhax2ztnlPx2UI3LUCD5ce6zlReb8sLN94C7x/f2OficfI5gw+iv 1KIafOT98R5owxEHowNSASLF5XES1u1rCxUJSCzJARu/6IGohbjtDoUtyrSP2iTN3cZQ WO0BQlYm7DJ0mZKyfo58xr3cbPrlbj2Pju6J/crGhpO7QQOZtlCK+2dMT79dwukZ/hup AemtZi7+WEDrtsMF5tvrCc3jvgDiVGVw02ja5j/0iQMokKGx+WFYHrbmKA9WY0gHc68x wAjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k5YdZ/Q5HaY7G+aox8l16f+nNDa2bGKMIjb1E5sWAtc=; b=EN2M/J35y/MD+9wB128A/Vzm+Xum70dmewH+TMPD8rI0k+zHZszAttEHke5GCISwgZ TBBUixsTDh/3O8igTb7fJ5Gsa0B0jhpoRonA2ajMVKlfm7qdhOP0XtZ5/g27/M2vSqYV PiJbmEkovqpAA0DBTibykiFlWXENJP4DQbN3IWJYV2/Rm7eTwgBO3tG7vKGQIsB5KoLF 0dFc/yiSRAdmSM7hUl5v4HW3Ja9Y95nKY3cJaXaUeBvBurgjKIjGK8pNtrWMBW9mTVbD QBzLwixXUXyBk7FjYK064O4etOEIZF9PSXo0f4pQKKycvkzVkk2jvubGiXlLj8r+J8pc c8TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UMNEGmiR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si19791261pfa.129.2019.04.24.10.34.35; Wed, 24 Apr 2019 10:34:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UMNEGmiR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391233AbfDXRdG (ORCPT + 99 others); Wed, 24 Apr 2019 13:33:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388062AbfDXRdD (ORCPT ); Wed, 24 Apr 2019 13:33:03 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4823621907; Wed, 24 Apr 2019 17:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556127182; bh=D8GwtsOkgfhmNDuUdQRdDMQKXlqUGS9YRVsWpKj2guA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UMNEGmiRSQKBkYThMx9VNtBTMpf06E2zwc9HWPKvV69AnTZmsr5PbUu5ohdAH2cvk ISrlFqMsRV0T3hKBSS/Z3fQbaiFeK5czvWHjqc4Fstferr6uIbJZ7ushWaU5gEkgY4 bQX/KUyh4rO4jA+4WZcO/U8y6PmhjKbRVgVoE0Ao= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Konstantin Khlebnikov , Vlastimil Babka , Roman Gushchin , Jann Horn , Andrew Morton , Linus Torvalds Subject: [PATCH 4.19 91/96] mm/vmstat.c: fix /proc/vmstat format for CONFIG_DEBUG_TLBFLUSH=y CONFIG_SMP=n Date: Wed, 24 Apr 2019 19:10:36 +0200 Message-Id: <20190424170925.976475295@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170919.829037226@linuxfoundation.org> References: <20190424170919.829037226@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Khlebnikov commit e8277b3b52240ec1caad8e6df278863e4bf42eac upstream. Commit 58bc4c34d249 ("mm/vmstat.c: skip NR_TLB_REMOTE_FLUSH* properly") depends on skipping vmstat entries with empty name introduced in 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in /proc/vmstat") but reverted in b29940c1abd7 ("mm: rename and change semantics of nr_indirectly_reclaimable_bytes"). So skipping no longer works and /proc/vmstat has misformatted lines " 0". This patch simply shows debug counters "nr_tlb_remote_*" for UP. Link: http://lkml.kernel.org/r/155481488468.467.4295519102880913454.stgit@buzz Fixes: 58bc4c34d249 ("mm/vmstat.c: skip NR_TLB_REMOTE_FLUSH* properly") Signed-off-by: Konstantin Khlebnikov Acked-by: Vlastimil Babka Cc: Roman Gushchin Cc: Jann Horn Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- mm/vmstat.c | 5 ----- 1 file changed, 5 deletions(-) --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1272,13 +1272,8 @@ const char * const vmstat_text[] = { #endif #endif /* CONFIG_MEMORY_BALLOON */ #ifdef CONFIG_DEBUG_TLBFLUSH -#ifdef CONFIG_SMP "nr_tlb_remote_flush", "nr_tlb_remote_flush_received", -#else - "", /* nr_tlb_remote_flush */ - "", /* nr_tlb_remote_flush_received */ -#endif /* CONFIG_SMP */ "nr_tlb_local_flush_all", "nr_tlb_local_flush_one", #endif /* CONFIG_DEBUG_TLBFLUSH */