Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp851194yba; Wed, 24 Apr 2019 10:36:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiJtutrH9gynEVdEMGoN/VEBthMrgSJxLrcuLiIhcZiR7IVIxV8qnVJow/3X87gs6KEbpu X-Received: by 2002:a63:165f:: with SMTP id 31mr32230988pgw.321.1556127413080; Wed, 24 Apr 2019 10:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556127413; cv=none; d=google.com; s=arc-20160816; b=HidGgH4t8jfOijPpv8u0nRjZp/BBTfVBpIN4QqrRpmezUNTu+Ux88TmcMuRC5/1F5m HEPLb45nTc4n4Gnr2W3G6293omRoWmXhUfOCbRo8b0HFBJhzREOMUM+O1MiTFMvN7D54 Im+qH/8Mjjo3w0GsX8HLkDIjUF5356lYWT/5CXNqsXntBFQS67VasSXI1LsoLiLbTk3I BsBE2IoXE0UPa3UUWuMTZbjZIXsRNVLR0FPAD1B2BA6Hw1mniDCMTK1q5fPb4j504GAP EOO+64pqJj2Ea4EcTD+qaj4ZRRiHZqU07oVrm4oPYHg2RxO6+MAf3Ajsj3N6XbRtoC4r UqeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wlv+Yenyul7YzZLVqkv3DpcjYFhOOrG1g4oIxJCXSkM=; b=neqYRH+ePF+nGtJUO5bffcSDKRKSsQp7IXwkVS0+kODOky6NKOPg2Nd1ekMMeI403B oLHS6nfpzikpXNEgc2AwVjFTVwQEvQ3JHRbodIvvs/Kxjig5dXj2jABwVKtSU4Bj+t0Q 5Va+lQJsCM/jVBPBmoT3sIbA4OqZSWmcYu62Bf1XGJrL0X1phT8tBfjuIPZZUnCRD4UP r+xJWffrrStbUno2Eie6CcxITI43Utxfzr7QMyBsUL1Fl47QiwiWnsgiSdAP/6iAhQg5 gR0hc7yqLI0cqpABv5zd6l3iERAZiG4VMAlx7WZxMY3Edt4yhqv9bj5Ae2tLYtZZw3sW D2Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Mh3pHloM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si11705198plq.240.2019.04.24.10.36.37; Wed, 24 Apr 2019 10:36:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Mh3pHloM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391601AbfDXRd4 (ORCPT + 99 others); Wed, 24 Apr 2019 13:33:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391585AbfDXRdw (ORCPT ); Wed, 24 Apr 2019 13:33:52 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D45382077C; Wed, 24 Apr 2019 17:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556127232; bh=+684G1eZOtnhpZivnpohq4hv5DP7GMPYHm7gUiyyVrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mh3pHloMFMNbFgei8l/XUs5YpZAyzWFVX6w5t0o/21YWPgf3Jl7jiccXGeM/Fkq8b vjV6fcYxJ/Vaftj2vNmNBuQ+HpgGGJoHG5cLvh2Di4x7yyxx507YSUKTFwHGfN+++7 SaJaEXJAL0ouWyHBtGbtzGc5JB+RT9kz5Znqkbv4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ido Schimmel , Jiri Pirko , "David S. Miller" Subject: [PATCH 5.0 016/115] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue Date: Wed, 24 Apr 2019 19:09:12 +0200 Message-Id: <20190424170925.986534185@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170924.797924502@linuxfoundation.org> References: <20190424170924.797924502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ido Schimmel [ Upstream commit a8c133b06183c529c51cd0d54eb57d6b7078370c ] The EMAD workqueue is used to handle retransmission of EMAD packets that contain configuration data for the device's firmware. Given the workers need to allocate these packets and that the code is not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM flag. Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock") Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlxsw/core.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c @@ -568,7 +568,7 @@ static int mlxsw_emad_init(struct mlxsw_ if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX)) return 0; - emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0); + emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0); if (!emad_wq) return -ENOMEM; mlxsw_core->emad_wq = emad_wq;