Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp855120yba; Wed, 24 Apr 2019 10:41:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBDDTUIx5gPp77Wlj0ZRmpsfMYZF3bZtUUvx06/J6JavZ8w/qkGyiCOBfcjTms8pCKQZOG X-Received: by 2002:a63:4411:: with SMTP id r17mr10568186pga.275.1556127661485; Wed, 24 Apr 2019 10:41:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556127661; cv=none; d=google.com; s=arc-20160816; b=R1pRno29l8tdVJDGVun6W6Bf/9QLHnqVfPBCNthsM7UHy5U6+6ApzdBaWNa8udNhQb hYSkHs7CsLBHfjPuAt6YjtM7Lzkp3e/8QWktAeS3Sdv9aYFIiwjD8TzLDWIEoZZQhz14 WWutbFswXVqL1+5BirclPj2mV5lA0nB/udSwLY6AOtEXsriIGNQ6AqFzoZXaz2WaRPNe 4200fcb1nzf6pQQeIKcD2RbYpxv6Jjd49yk8/trSxaiUusv1jd91Y09QLtUBQbOo0tHJ /IEpkaGanz263okhwt5UFThh+OAJhdoAvrRVHhx3jbsROwUoUbgAfTfVWDw+KxHmtjZS KhZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5wYl0g6LL5JYkSCT8gVZS9neSBRgG51qZK0EThwUukc=; b=ThMHaFfsxXc51un70aoqTHH1xbu6MyiTSDxBg24qNPwePXKl/hlle0ka4hFVpPWHjT M43MaJD8aoetu7gnlLwGnV4Kis/k5Rip7JR0mEJXNVw/rqjhe8d/h+bTkypaju4vHdIU kMPbyQY04ePNP8ls9QknIzVkGdksgGcTc0EMylGpWPFxdXai+Ylw+3Vt2aRjzNWRpYHb OzQ1QzsYh6/UOP3SOIqIAA0ZkdFg9z7svVC/DmwRSuX2mJpmkUwYA5SGc8caVv9WouXY zECj+yGSf7FwIW3QR/ZP3LS662bMKPPQ0Sk6oTcyVToVQ+YRVEH7sk3j2XhljHk2mixb Tfbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=o1DJ3Km9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si19810482plk.421.2019.04.24.10.40.46; Wed, 24 Apr 2019 10:41:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=o1DJ3Km9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388465AbfDXRh5 (ORCPT + 99 others); Wed, 24 Apr 2019 13:37:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:37014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392294AbfDXRhy (ORCPT ); Wed, 24 Apr 2019 13:37:54 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E2562054F; Wed, 24 Apr 2019 17:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556127474; bh=Z38Q4RplQPvZdRj9T13BK59Dr2zpud/8AU35EjdsxFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o1DJ3Km9n5eNvBcWVc/gW10vt9JQ/La4Bmh0wzVS5TMGggpmx1QEemVl4Hh3E8uy1 UaZx0M6H5P1EUyWLg9RDN3AxvKfbKTlWETtNWQCeaNyCMo7PYTEf+q5LB4UKuKVSko vJYD6wdaYsoNUt/35QU1DmF9ItZG44gdwDKZZ94o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jarkko Sakkinen , Stefan Berger , Jerry Snitselaar , Sasha Levin Subject: [PATCH 5.0 104/115] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Date: Wed, 24 Apr 2019 19:10:40 +0200 Message-Id: <20190424170930.802843924@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170924.797924502@linuxfoundation.org> References: <20190424170924.797924502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 442601e87a4769a8daba4976ec3afa5222ca211d ] Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: stable@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen Reviewed-by: Stefan Berger Reviewed-by: Jerry Snitselaar Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm_i2c_atmel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c index 32a8e27c5382..cc4e642d3180 100644 --- a/drivers/char/tpm/tpm_i2c_atmel.c +++ b/drivers/char/tpm/tpm_i2c_atmel.c @@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len) if (status < 0) return status; + /* The upper layer does not support incomplete sends. */ + if (status != len) + return -E2BIG; + return 0; } -- 2.19.1