Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp867226yba; Wed, 24 Apr 2019 10:53:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdX5r9M4FyfwATCwvirc9Wlxm3fVCSYXJckiknpjWmC/yu4FVMsxM7Yy9jIrNDVt1DU7/U X-Received: by 2002:a65:608d:: with SMTP id t13mr8193277pgu.406.1556128429934; Wed, 24 Apr 2019 10:53:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556128429; cv=none; d=google.com; s=arc-20160816; b=KryZlQnxZHsMXYiL5treUKF9IuGEeWjDl/RTo6Mp2mIKQM6SwAouR0A3iUD8k/9CFo PRzWGvu2PafwbWskWvyTWlqR1u63Z4Vtj9S+nR/OsUn00lKHvbH2/C3JM5UF1pNkNC6V fOzm+EQ3vbdoBsmgsCOuAkvIKhvywYKSz28zs4JYmxClqRvfLV6ITfuOkFneL1pR8wp7 +JdGhP+oFieYHjM55vSLuIcy8yqtoEPEU81H+OXTApWhksG/fmfKlan+PpNCNEBFSkvv 5/DUd0f6kTR3KgnCSU0qqN5VSViZFSPexTnFJbVQKan0Qgjyi8lYc3PEzM8FdnF4dFEU 6RiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5wYl0g6LL5JYkSCT8gVZS9neSBRgG51qZK0EThwUukc=; b=Xbf7eRBTQInDPJm2PVmYu/k8m/IXXFNfo/pICOSaCsMeFGX4JqFm69R68NHy/Eg7LV A3iVeNXnDrowwBzvdPYYkQsSET2W3+wG9Mm2qjV6lQHsveozjeXIXnoQx6XNAZfQ+oql uNf7415LXefz3iupbLMMpH2Ve6FxDjsKDrIRdQ3xTQmRx07kcLaRkUTYdNOBHsQ+TjeP itl4jTrCHeJY2kRQeoBCK81oCl1DcVqsosAmyc0ql6ttluzC6KE8CyRLf8R/yY6UjlVh ct+DHbpCM66NM7u8zngVXOpG8+mE1BUPnOB0OZpPQvXZIfRYTVbb666lmy8Jyqw5bg9j dQ+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Df//gglS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si18267189pgb.292.2019.04.24.10.53.34; Wed, 24 Apr 2019 10:53:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Df//gglS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390650AbfDXR2R (ORCPT + 99 others); Wed, 24 Apr 2019 13:28:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:54470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389906AbfDXR2P (ORCPT ); Wed, 24 Apr 2019 13:28:15 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38DBE206BA; Wed, 24 Apr 2019 17:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126894; bh=Z38Q4RplQPvZdRj9T13BK59Dr2zpud/8AU35EjdsxFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Df//gglSPjcUAg3eXRk1uqnS3JBZ+boM3K/S0WVJsZNS9F7WPfmu9aGpCoUjgH+ti dl+rBMSd31sAR4s02NDix/IGGYH9aJAq41ddLMUXEyz7YPsT66JspIapcXYGeYl0eZ 8sIWBhIEg575HVy4j1W+2HT7O32ZrGftl7NiY8TQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jarkko Sakkinen , Stefan Berger , Jerry Snitselaar , Sasha Levin Subject: [PATCH 4.14 54/70] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Date: Wed, 24 Apr 2019 19:10:14 +0200 Message-Id: <20190424170917.424006942@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170906.751869122@linuxfoundation.org> References: <20190424170906.751869122@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 442601e87a4769a8daba4976ec3afa5222ca211d ] Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: stable@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen Reviewed-by: Stefan Berger Reviewed-by: Jerry Snitselaar Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm_i2c_atmel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c index 32a8e27c5382..cc4e642d3180 100644 --- a/drivers/char/tpm/tpm_i2c_atmel.c +++ b/drivers/char/tpm/tpm_i2c_atmel.c @@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len) if (status < 0) return status; + /* The upper layer does not support incomplete sends. */ + if (status != len) + return -E2BIG; + return 0; } -- 2.19.1