Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp879288yba; Wed, 24 Apr 2019 11:05:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrP4HYicPikrDxIAnyX2n3xVvaP7A2k2A7wHFhq1JMCWZ/nyjR6LDMQ91X8M47FDrN6Dkg X-Received: by 2002:a65:430a:: with SMTP id j10mr32485621pgq.143.1556129111068; Wed, 24 Apr 2019 11:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556129111; cv=none; d=google.com; s=arc-20160816; b=fk1reglbl+j3BxnoCz6ZYGonlDvvxjIHADf/JaatIZDDdKBodpPIfukxllm9rGaFn2 1awYMJlTteqv2wDdIXCgjh8Ar5WXW+3bL0+3/vPxwAjCWw0WcTCUA0jddGoJ793ini9C IlwB5b854PpbIKJXLXq5EP2DaZvczSQem8jW+pz7HbUUNkSr397g1LOx5iVCSTUJdqsj BB9CqJDKcdi8BwfSrTs2gNAMLzOTncpTvu1UQJMEzOnAnAwAcnr2ewxK1khDK26ptQGa rN65sEb8JjVxHJCLdbHjXU7xHRmi7klrIRwqLDZJ/kRmEE74HbrkCV98qsbZGQdHuMM0 xZxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q5EFrtflRbb4/QjZ4kggLuw025r7+IGKkcHzh6shwV0=; b=IsTqJUL5vTPg+2DQew7Fz1kCiRt+7Csee0AcLWQ1EVmKliXxI4SATzaO2SpbiGHdYC 0dLmN1ifIjyZY8FcOxSq3glp1U7zA13WkpTRd/nR1SpQPdoojJuE4T+2evuSk0YpFksN 1eIuRGYa1JXUx9GM4jATUTDRQxe0BKU3VooWdrME4v+UNb2spu7ba2e0hiR1kVjCbWLw xJvK61yvtmXqnSBBHl6Wzr9GhP5nHgBmSQ9711caEp3ANWoPUBvUw4+DxOSl4P8pb1G/ A50Wtk+rm6A5NOWmQ7PALRgg/l5dEqQ90IIsgxupGlxaGRPxt6hE79a88a8V/5FeRH/L yxpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="G7oB4f/i"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si20667964pfv.192.2019.04.24.11.04.55; Wed, 24 Apr 2019 11:05:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="G7oB4f/i"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389173AbfDXRU3 (ORCPT + 99 others); Wed, 24 Apr 2019 13:20:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:45766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389168AbfDXRU2 (ORCPT ); Wed, 24 Apr 2019 13:20:28 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 001F6205ED; Wed, 24 Apr 2019 17:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126427; bh=nG4pVa9jMLB6NoMhhciXMQjdQm5NXSzrGTo7He0y9yg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G7oB4f/i8WR2tRZRrs+wMzwJsDMVqXwFJxbb26kpwllyHkZwcfPo1PSJAHNSj6Hjb YpHKy89/spc03TWRXS8X20q+yyyb6MDlkASGR00+4wouDbjkvRUz5PsdF3T9F2Klwm 3LNErhx8AdlRDPcRpwzyGzijr907Q1N9em0hog30= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Garrett , Zhang Rui , Sasha Levin Subject: [PATCH 4.4 107/168] thermal/int340x_thermal: fix mode setting Date: Wed, 24 Apr 2019 19:09:11 +0200 Message-Id: <20190424170929.896293858@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170923.452349382@linuxfoundation.org> References: <20190424170923.452349382@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 396ee4d0cd52c13b3f6421b8d324d65da5e7e409 ] int3400 only pushes the UUID into the firmware when the mode is flipped to "enable". The current code only exposes the mode flag if the firmware supports the PASSIVE_1 UUID, which not all machines do. Remove the restriction. Signed-off-by: Matthew Garrett Signed-off-by: Zhang Rui Signed-off-by: Sasha Levin --- drivers/thermal/int340x_thermal/int3400_thermal.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c index 0beed2899163..d4c374cc4f74 100644 --- a/drivers/thermal/int340x_thermal/int3400_thermal.c +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c @@ -285,10 +285,9 @@ static int int3400_thermal_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); - if (priv->uuid_bitmap & 1 << INT3400_THERMAL_PASSIVE_1) { - int3400_thermal_ops.get_mode = int3400_thermal_get_mode; - int3400_thermal_ops.set_mode = int3400_thermal_set_mode; - } + int3400_thermal_ops.get_mode = int3400_thermal_get_mode; + int3400_thermal_ops.set_mode = int3400_thermal_set_mode; + priv->thermal = thermal_zone_device_register("INT3400 Thermal", 0, 0, priv, &int3400_thermal_ops, &int3400_thermal_params, 0, 0); -- 2.19.1