Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1554103457-29595-1-git-send-email-yannick.fertre@st.com> <7ff86999-02e5-ef48-221c-a5e0e61eb2fd@st.com>
In-Reply-To: <7ff86999-02e5-ef48-221c-a5e0e61eb2fd@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 24 Apr 2019 14:25:41 +0200
Message-ID: <CA+M3ks5M1NXWj1dew9DcNfOhYeFbWZ6iVYDcvQr6auVAKUnVyA@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid
 partial refresh
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le lun. 1 avr. 2019 =C3=A0 11:22, Philippe CORNU <philippe.cornu@st.com> a =
=C3=A9crit :
>
> Dear Yannick,
> Thank you for your patch, works fine,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> On 4/1/19 9:24 AM, Yannick Fertr=C3=A9 wrote:
> > Plane updates must be synchronized on vblank with the shadow register m=
echanism
> > to avoid partial refresh on screen.
> >
> > Signed-off-by: Yannick Fertr=C3=A9 <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..c2d0800 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -426,8 +426,8 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc=
 *crtc,
> >       /* Enable IRQ */
> >       reg_set(ldev->regs, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
> >
> > -     /* Immediately commit the planes */
> > -     reg_set(ldev->regs, LTDC_SRCR, SRCR_IMR);
> > +     /* Commit shadow registers =3D update planes at next vblank */
> > +     reg_set(ldev->regs, LTDC_SRCR, SRCR_VBR);
> >
> >       /* Enable LTDC */
> >       reg_set(ldev->regs, LTDC_GCR, GCR_LTDCEN);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel