Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Apr 2019 08:25:58 -0500
From:   Corey Minyard <minyard@acm.org>
To:     Kamlakant Patel <kamlakantp@marvell.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openipmi-developer@lists.sourceforge.net" 
        <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH] ipmi: add i2c-addr property to ipmi platform device
Message-ID: <20190424132558.GB6623@minyard.net>
Reply-To: minyard@acm.org
References: <1556099251-11408-1-git-send-email-kamlakantp@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1556099251-11408-1-git-send-email-kamlakantp@marvell.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 24, 2019 at 09:48:36AM +0000, Kamlakant Patel wrote:
> We need 'i2c-addr' property entry for ssif to work.
> Otherwise, it thorws following error:
> "ipmi_ssif dmi-ipmi-ssif.0: ipmi_ssif: No i2c-addr property"

The patch really isn't right, you only want to add the i2c-addr
property if the interface is SSIF.  But there's no easy way to
tell this in the current code.  I'll work something up.

Also, your mailer has added DOS line endings to all your
patches and I can't apply them cleanly.  If there's any way
you can use git-send for sending patches, that would be ideal.

-corey

> 
> Signed-off-by: Kamlakant Patel <kamlakantp@marvell.com>
> ---
>  drivers/char/ipmi/ipmi_plat_data.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/char/ipmi/ipmi_plat_data.c b/drivers/char/ipmi/ipmi_plat_data.c
> index 8f0ca2a..1075076 100644
> --- a/drivers/char/ipmi/ipmi_plat_data.c
> +++ b/drivers/char/ipmi/ipmi_plat_data.c
> @@ -34,6 +34,8 @@ struct platform_device *ipmi_platform_add(const char *name, unsigned int inst,
>  		p->regspacing = p->regsize;
>  
>  	pr[pidx++] = PROPERTY_ENTRY_U8("ipmi-type", p->type);
> +	if (p->addr)
> +		pr[pidx++] = PROPERTY_ENTRY_U16("i2c-addr", p->addr);
>  	if (p->slave_addr)
>  		pr[pidx++] = PROPERTY_ENTRY_U8("slave-addr", p->slave_addr);
>  	pr[pidx++] = PROPERTY_ENTRY_U8("addr-source", p->addr_source);
> -- 
> 1.8.3.1
>